Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSC_INSTALLER_LINK environment variable isn't picked up #560

Closed
jwheare opened this issue Jul 2, 2016 · 7 comments · May be fixed by qcif/data-curator#563
Closed

CSC_INSTALLER_LINK environment variable isn't picked up #560

jwheare opened this issue Jul 2, 2016 · 7 comments · May be fixed by qcif/data-curator#563
Labels

Comments

@jwheare
Copy link
Contributor

jwheare commented Jul 2, 2016

  • Version: 5.10.3
  • Target: "mac": { "target": ["dmg", "zip", "mas"] }

When building for both mac and mas I have CSC_LINK, CSC_KEY_PASSWORD, CSC_INSTALLER_LINK, CSC_INSTALLER_KEY_PASSWORD set and using CSC_IDENTITY_AUTO_DISCOVERY=false to bypass my keychain because this will eventually be run on CI.

From looking at the code it seems like the CSC_INSTALLER_LINK environment variable isn't being used anywhere, and as a result I'm getting the error:

Error: Signing is required for mas builds but CSC_INSTALLER_LINK is not specified

This works fine with auto discovery, just not environment variables.

Also, is it possible to specify two separate CSC_LINK files, one for mas builds and one for non-mas. I intend to distribute our application both on the store and via our website. I guess two separate builds could be run from the command line with separate environment and target rules, but this seems cumbersome.

@develar develar added the feature label Jul 2, 2016
@develar
Copy link
Member

develar commented Jul 3, 2016

Solution:

  • Multi-cert p12 must be supported.
  • Use the same auto discovery logic on CI for created temp keychain instead of explicit identity resolving using openssl.

Will be fixed soon.

@develar
Copy link
Member

develar commented Jul 3, 2016

CSC_INSTALLER_LINK supported restored. This issue remains open because of "is it possible to specify two separate CSC_LINK files".

@jwheare
Copy link
Contributor Author

jwheare commented Jul 5, 2016

I'm excited!

@jwheare
Copy link
Contributor Author

jwheare commented Jul 7, 2016

I'm getting this error now (with only CSC_LINK and CSC_KEY_PASSWORD set):

Unhandled rejection Error: keychainName is null, but CSC_LINK defined

@develar
Copy link
Member

develar commented Jul 7, 2016

@jwheare Fixed in the next release (will be in 20 minutes).

@jwheare
Copy link
Contributor Author

jwheare commented Jul 7, 2016

Thanks, confirmed this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants