Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Win64 system wide checkForUpdatesAndNotify() uninstalls but doesn't install #5468

Closed
timvdalen opened this issue Dec 11, 2020 · 10 comments
Closed

Win64 system wide checkForUpdatesAndNotify() uninstalls but doesn't install #5468

timvdalen opened this issue Dec 11, 2020 · 10 comments

Comments

@timvdalen
Copy link

  • Version: 22.9.1
  • Electron Version: 10.1.5
  • Electron Type (current, beta, nightly): current
  • electron-updater Version: 4.3.5
  • Target: win64

I'm running a generic server auto-update on Windows using NSIS.
Auto update works correctly if the application is installed per-user, but when the application is installed system wide:

  1. The user launches an old version of the app
  2. The user receives a notification that the app is ready to update on close
  3. The user closes the app and received a UAC popup for old-uninstaller.exe (from a temporary folder)
  4. The user gives permission
  5. The old version of application is deleted
  6. Nothing else happens

Expected behaviour
The new version of the application is installed
@timvdalen
Copy link
Author

timvdalen commented Dec 11, 2020 •
edited
Loading

I unfortunately don't have any interesting logs for this behaviour, the app simply logs that it has found an update and is going to execute it.

@stale
Copy link

stale bot commented Feb 13, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Feb 13, 2021
@timvdalen
Copy link
Author

Still relevant. I've donated to the project to see if this can get priority.

@stale stale bot removed the backlog label Feb 13, 2021
@randomgithubuser1
Copy link

I'm also having this same issue. It seems there is an issue with silent update and machine wide installation.

Another thread about it here: #4474

There is a solution in that thread that checks the registry and sets isSilent to false if the app is installed for all users.

I'm not sure how to set isSilent when using checkForUpdatesAndNotify() though since it doesn't look like it accepts any arguments.

@mansoor93 mansoor93 mentioned this issue Jun 16, 2021
Closed
@stale
Copy link

stale bot commented Jul 8, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Jul 8, 2021
@timvdalen
Copy link
Author

@Yorannn can you link to the workaround that ended up working for us?

@stale stale bot removed the backlog label Jul 8, 2021
@stale
Copy link

stale bot commented Sep 7, 2021

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Sep 7, 2021
@Yorannn
Copy link

Yorannn commented Sep 14, 2021

@Yorannn can you link to the workaround that ended up working for us?

This was the workaround I used
#2363

@stale stale bot removed the backlog label Sep 14, 2021
krisdages added a commit to krisdages/electron-builder-lib-slim that referenced this issue Nov 20, 2021
@krisdages
fix(nsis): silent upgrade of per-machine installation is not elevated (…
1fc0806 
…electron-userland#5468)

Without elevation, app is uninstalled, but new files can't be extracted
 and no error message is displayed.
@robertpatrick robertpatrick mentioned this issue Nov 28, 2021
Merged
mmaietta pushed a commit that referenced this issue Nov 30, 2021
@robertpatrick
fix(nsis): per-machine installs must properly elevate during silent i…
661a652 
…nstall/updates (#6450)

* fix(nsis): fix per-machine installs

Add @krisdages changes from PR #6438 to elevate silent per-machine installs.
Remove PR #6073 that incorrectly elevates all per-machine installs, breaking interactive per-machine installs.

Closes #6425, #5468

Co-authored-by: Robert Patrick
Co-authored-by: Kris Dages
@stale
Copy link

stale bot commented Apr 17, 2022

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Apr 17, 2022
@timvdalen
Copy link
Author

Should be fixed by #6450

@stale stale bot removed the backlog label Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@timvdalen @mmaietta @Yorannn @randomgithubuser1