-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
electron-builder does not respect yarn workspace and pulls in incorrect version into bundled app #4516
Comments
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sure.
Some feedback from the maintainers; whether it is a bug or not, seems to be a defect though.
I even set up a repository with the steps to reproduce, what else should I do, dear stale bot? |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
The app directory is not included by workspaces for electron-builder See: electron-userland/electron-builder#4516
Did you manage to solve this? I've got the same issue #8519 (comment) |
21.2.0
macOS, dmg
When I use
yarn
workspaces, theelectron-builder
does not handle the versions correctly and pulls in an incorrect version into the final app's dependencies.I set up a repo to reproduce it, and described the oddity here.
Steps to reproduce:
yarn
yarn --cwd ./examples/app start
and check the version,yarn --cwd ./examples/app package
and check the version.Can someone please verify whether it is a bug or a missing feature? Or is my expectation about the versions correct at all?
Thank you!
The text was updated successfully, but these errors were encountered: