Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron-builder does not respect yarn workspace and pulls in incorrect version into bundled app #4516

Closed
kittaakos opened this issue Dec 7, 2019 · 5 comments
Labels

Comments

@kittaakos
Copy link

  • Version:
    21.2.0
  • Target:
    macOS, dmg

When I use yarn workspaces, the electron-builder does not handle the versions correctly and pulls in an incorrect version into the final app's dependencies.

I set up a repo to reproduce it, and described the oddity here.

Steps to reproduce:

  • yarn
  • start the electron app: yarn --cwd ./examples/app start and check the version,
  • package the electron app: yarn --cwd ./examples/app package and check the version.

Can someone please verify whether it is a bug or a missing feature? Or is my expectation about the versions correct at all?

Thank you!

@stale
Copy link

stale bot commented Feb 5, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Feb 5, 2020
@kittaakos
Copy link
Author

Is this still relevant?

Sure.

If so, what is blocking it?

Some feedback from the maintainers; whether it is a bug or not, seems to be a defect though.

Is there anything you can do to help move it forward?

I even set up a repository with the steps to reproduce, what else should I do, dear stale bot?

@stale stale bot removed the backlog label Feb 5, 2020
@stale
Copy link

stale bot commented Apr 5, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Apr 5, 2020
@stale stale bot closed this as completed Apr 12, 2020
5000164 added a commit to 5000164/base that referenced this issue Feb 1, 2021
The app directory is not included by workspaces for electron-builder
See: electron-userland/electron-builder#4516
@mifi
Copy link
Contributor

mifi commented Oct 27, 2024

Did you manage to solve this? I've got the same issue #8519 (comment)

@beyondkmp
Copy link
Collaborator

@mifi I have tested electron-builder v25.1.8 and it has resolved the issue in #4516 (electron v21). Could you please test if v25.1.8 has resolved your issue as well?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants