Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron-updater mac .dmg throw RR_UPDATER_ZIP_FILE_NOT_FOUND #4230

Closed
dapengJia opened this issue Sep 12, 2019 · 2 comments
Closed

electron-updater mac .dmg throw RR_UPDATER_ZIP_FILE_NOT_FOUND #4230

dapengJia opened this issue Sep 12, 2019 · 2 comments
Labels
backlog

Comments

@dapengJia
Copy link

MacUpdater findFile(files, "zip", ["pkg", "dmg"])
findFile:files.find(fileInfo => !not.some(ext => fileInfo.url.pathname.toLowerCase().endsWith(.${ext})))

Is the .pkg and .dmg formats not supported? Returns undefined when in dmg format?
@dapengJia dapengJia changed the title electron mac .dmg throw RR_UPDATER_ZIP_FILE_NOT_FOUND electron-updater mac .dmg throw RR_UPDATER_ZIP_FILE_NOT_FOUND Sep 12, 2019
@stale
Copy link

stale bot commented Nov 11, 2019

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Nov 11, 2019
@stale stale bot closed this as completed Nov 18, 2019
@oskarhane
Copy link

Plus one on this. It would be great to being able to have other targets than zip for updates.
Zip has issues with notarization so updates are currently broken on MacOS Catalina.

@karanbirsingh karanbirsingh mentioned this issue Feb 12, 2020
Merged
7 tasks
dbjorge pushed a commit to microsoft/accessibility-insights-web that referenced this issue Feb 12, 2020
@karanbirsingh
fix: enable updates on mac for the unified client (#2153)
a914300 
This PR enables updates for the macOS electron product. High level changes include:
- we add a zip file target because of electron-userland/electron-builder#4230
- we create the zip file ourselves because of electron-userland/electron-builder#3534 (comment)
- we update latest.yml to reflect the new zip file in the artifact
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oskarhane @dapengJia