Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--dist by default and remove this flag in favour of --target=dir #413

Closed
develar opened this issue May 17, 2016 · 2 comments · May be fixed by qcif/data-curator#563
Closed

--dist by default and remove this flag in favour of --target=dir #413

develar opened this issue May 17, 2016 · 2 comments · May be fixed by qcif/data-curator#563

Comments

@develar
Copy link
Member

develar commented May 17, 2016

A lot of users complain about it. Since mas was implemented, we have new target option in the configuration. And it will be soon supported for other OS — zip, 7z targets.

Proposal:

  • Add --osx, --linux and --win flags. Value: list of supported os-specific targets.
  • Add --target flag. Value: list of common targets (zip) or unique target (mas, dmg).
  • Remove --dist flag. Replacement: --target=dir if you want to get unpacked app. i.e. by default we will build in distributable format.
  • Hide --platform flag (we cannot remove to be compatible with electron-packager, so, we just hide it). Replacement: --win or --osx. To build all platforms: --target=default (i.e. if target is common or has special meaning (default means use default target)).

Result:

  • improve user-friendly — since we will build in a distributable format by default.
  • clear CLI — remove --dist/--platform flags in favour of unified --target.
  • ability to set target (e.g. mas) using CLI (if you want to experiment and don't want to change package.json yet).

cc @d9k @nickhudkins

@Vj3k0
Copy link

Vj3k0 commented May 22, 2016

I like the idea of changing --platform in favor of specific OS flags. It's way cleaner for use.
Maybe something like:

build --osx [ia32|x64] --win [ia32|x64] --linux [ia32|x64]

Architecture specification is optional. If not defined, it can build both by default. So you can kick out --arch as well.

Currently, you'll get .dmg and .zip for OSX, and .exe and .nupkg for Windows, right? I mean, if mas is only exception, would it be easy to define --mas? So for folks that want to make OSX builds, they just do:

build --osx --mas --win 

...which would create binaries for Win, OSX and App store.

Even better:

-o --osx
-w --win
-l --linux

then you can do extra cool: build -owl :-D

@develar
Copy link
Member Author

develar commented May 22, 2016

@Vj3k0 Thanks, so, I will do it.

I mean, if mas is only exception

No, numerous targets — #414 (comment)

develar added a commit to develar/electron-builder that referenced this issue May 28, 2016
…=dir electron-userland#413

BREAKING CHANGE: `appDir` CLI is removed — use [directories.app](https://github.com/electron-userland/electron-builder/wiki/Options#MetadataDirectories-app) in the development package.json. `sign` CLI is removed — use [build.osx.identity](https://github.com/electron-userland/electron-builder/wiki/Options#OsXBuildOptions-identity) in the development package.json.
develar added a commit to develar/electron-builder that referenced this issue May 28, 2016
…=dir electron-userland#413

BREAKING CHANGE: `appDir` CLI is removed — use [directories.app](https://github.com/electron-userland/electron-builder/wiki/Options#MetadataDirectories-app) in the development package.json. `sign` CLI is removed — use [build.osx.identity](https://github.com/electron-userland/electron-builder/wiki/Options#OsXBuildOptions-identity) in the development package.json.
develar added a commit to develar/electron-builder that referenced this issue May 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants