Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplatform Build Documentation is lacking. I can fix! #412

Closed
framerate opened this issue May 16, 2016 · 10 comments
Closed

Multiplatform Build Documentation is lacking. I can fix! #412

framerate opened this issue May 16, 2016 · 10 comments

Comments

@framerate
Copy link

I can issue a PR but I need to understand it first.

What I'd like to do (and seems possible from documentation) is build OSX and Windows files from OSX (no MSI).

The documentation linked (https://github.com/electron-userland/electron-builder/wiki/Multi-Platform-Build) says it's possible but I'd like to add the actual commands to this page if you could point me in the right direction.

Once I figure it out I'll issue a PR. Thanks!

@develar
Copy link
Member

develar commented May 17, 2016

if you could point me in the right direction.

Edit file https://github.com/electron-userland/electron-builder/blob/master/docs/Multi%20Platform%20Build.md (see https://github.com/electron-userland/electron-builder/blob/master/CONTRIBUTING.md#documentation)

I'd like to add the actual commands to this page

If it can be somehow simplified (since we are smart tool), it should be done. Anyway, please open PR and it will be discussed.

@framerate
Copy link
Author

@develar That's the page I'm referring to. There is no real directions i can see.

The directions are "install these two apps in homebrew". But then what? I've scoured the issue tracker and seen you can pass --platform and --arch commands but that doesn't seem to work. That's the missing step I want to add.

The assumption by me, the user of the documentation, is that I install those through brew and then npm run dist and OSX and Windows should just magically build for me! (according to this). But whatever the missing command line flag is to make Windows build on OSX seems to be missing :(

@develar
Copy link
Member

develar commented May 17, 2016

--platform and --arch commands but that doesn't seem to work

It works. Yes, this should be documented.

@framerate
Copy link
Author

Are those pass-throughs to electron-packager or anything that I can see the list of valid commands?

@develar
Copy link
Member

develar commented May 17, 2016

I can see the list of valid commands?

https://github.com/electron-userland/electron-builder#cli-usage

Just pass these args in your script task. "dist-win": "build --platform=win32"

@framerate
Copy link
Author

Great. And is it not possible to create the update files (RELEASES, project.nupkg, project.exe) for Windows while using OSX?

@framerate
Copy link
Author

Thanks I got it, I'll try and clean up the documentation tomorrow to make it clearer!

@develar
Copy link
Member

develar commented May 19, 2016

is it not possible to create the update files (RELEASES, project.nupkg, project.exe) for Windows while using OSX?

Possible. Just install required tools (as stated in the docs). FYI: docker support is coming

@ilDon
Copy link

ilDon commented Jun 6, 2016

Just pass these args in your script task. "dist-win": "build --platform=win32"

This should definitely be in the docs! :-)

@develar
Copy link
Member

develar commented Jun 6, 2016

This should definitely be in the docs! :-)

--win :)

develar added a commit to develar/electron-builder that referenced this issue Jun 11, 2016
develar added a commit to develar/electron-builder that referenced this issue Jun 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants