-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to build for mac app store? #332
Comments
Not yet supported, it is easy to do, will be fixed tomorrow. |
Awesome response @develar I dont know how much you know about this. I have up to now been using The package is built with the tool productbuild - basically I run
Please beaware that its nessesary to use a different signing key to the one used to sign the The app one is something like '3rd Party Mac Developer Application: Company (XXX)' and the installer one is '3rd Party Mac Developer Installer: Company (XXX)' It would be best to have a separate option for the name of the key incase I need to call it something custom. |
@mcfedr Thanks for details. Yes – our current issue is that we don't use https://github.com/electron-userland/electron-osx-sign and don't use |
Yes, I was just looking at |
@develar it would be amazing if this could be added ASAP. Adding it to my book. Can you confirm that this would be the correct way to set the platform to MAS? "scripts": {
...
"pack": "build",
...
},
"build": {
...
"platform": "mas",
...
} |
@adam-lynch I am working on it right now. Fix will be published tomorrow morning.
No. Implemented as "set |
@develar great thanks! |
@mcfedr Thank you for links, it was very useful. Your feedback is important, please try 3.11 ( |
would be really nice if I could pass to the build options the name for signing, not use the same one as for app signing - https://github.com/electron-userland/electron-builder/blob/master/src/macPackager.ts#L69 |
And now I dont get a normal osx build |
Do you mean
is not suitable for you? |
What's wrong? |
sign: I am starting the build from gulp - there is lots of other stuff that has to happen before electron builder is called - I would prefer to pass as the signing keys as options to the build function, as it is I did Personally, I wont want to use the cli, It makes sense to me to build a solid API, and the cli on top of that, such that I am not forced to use the cli. There are reasons why I want to be able to pass args in from gulp - some of my devs work on linux, i want them to be able make linux/windows builds - so i detect in gulp what platforms they are running on and pass only the platforms they can build for to the build function. osx build: I dont get a 'normal' darwin build in the release folder, I have put |
@mcfedr Thanks for detailed feedback. All your points is valid and confirmed.
Why do you want to build both if you distribute app using MAS? (no doubt, it will be fixed, but I want to know exactly why). |
I need both because I use one for distributing to testers and one for the store - although actually the mas build is probably ok for that as i dont need the auto-update functionality. Either way, I feel like this should be my choice :) Also, to me its a bit strange to use a separate 'target' option, when both |
Your case exactly is a reason. "need both because I use one for distributing to testers and one for the store". Otherwise on execute "platform darwin" you will get "zip" + "dmg", but for testers you want only DMG (or, may be, just zip/7z). So, |
Seems like i would just use |
@mcfedr But configuration is the same ( So, we decided to keep platform as OS only. |
3.14 — you can build dmg and mas. or 7z. ( |
Proposal: Add So, it will be easy to pass it using programmatic API: build({
devMetadata: {
build: {
osx: {
identity: "my name"
},
mas: {
identity: "my installer name"
}
}
}
}) |
Add Programmatic Usage example Closes electron-userland#332
Recommended way to provide entitlements — files |
@develar these changes sound great, i'm going to check them out when im back at work |
Just wanted to say thanks, got my mas and dmg builds working. Things are good! |
Thanks, I'm currently only signing with apple certs so its not a problem. It might be of help, we use this tool, https://github.com/ekreative/xcode-build-tools, for helping create a keychain on CI server |
I cannot see to set the
platform
ortarget
setting tomas
electron-packager
acceptsmas
asplatform
The text was updated successfully, but these errors were encountered: