Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows installer metadata is incorrect #278

Closed
ghost opened this issue Mar 29, 2016 · 2 comments · May be fixed by qcif/data-curator#563
Closed

Windows installer metadata is incorrect #278

ghost opened this issue Mar 29, 2016 · 2 comments · May be fixed by qcif/data-curator#563

Comments

@ghost
Copy link

ghost commented Mar 29, 2016

I am generating a Windows installer (on Windows) using version 3.1.1. I noticed that the generated installer has "[object Object]" as the value for both "File description" and "Product name".

properties

The application executable itself has the correct values.

Examining the nuspec template in node_modules/electron-winstaller-fixed/lib/index.js shows where the issue might be:

    const nuspecContent = `<?xml version="1.0" encoding="utf-8"?>
<package xmlns="http://schemas.microsoft.com/packaging/2010/07/nuspec.xsd">
  <metadata>
    <id>${ metadata.name }</id>
    <title>${ metadata.title }</title>
    <version>${ convertVersion(metadata.version) }</version>
    <authors>${ metadata.authors || metadata.owners }</authors>
    <owners>${ metadata.owners || metadata.authors }</owners>
    <iconUrl>${ metadata.iconUrl }</iconUrl>
    <requireLicenseAcceptance>false</requireLicenseAcceptance>
    <description>${ metadata }</description>   <!-- This accounts for the incorrect description -->
    <copyright>${ copyright }</copyright>
  </metadata>
....
@havenchyk
Copy link
Contributor

Have the same bug (probably with 3.1.0) as well.

@develar
Copy link
Member

develar commented Mar 30, 2016

@havenchyk regression introduced by commit develar/windows-installer@8f76c91 (branch builder) I added you as collaborator, so, you can fix it and publish electron-winstaller-fixed module because I am on vacation now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants