Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Electron showing after upgrading from 19.47.1 to 19.53.0 #2617

Closed
gschier opened this issue Feb 21, 2018 · 1 comment · May be fixed by qcif/data-curator#563
Closed

Default Electron showing after upgrading from 19.47.1 to 19.53.0 #2617

gschier opened this issue Feb 21, 2018 · 1 comment · May be fixed by qcif/data-curator#563

Comments

@gschier
Copy link

gschier commented Feb 21, 2018

  • Version: Tested on 19.47.1, 19.53.0, and 20.0.8
  • Target: Linux (deb, AppImage)

This issue was first discussed in #2577 (comment)

The problem is that my build suddenly started showing the default Electron icon after upgrading electron-builder from from 19.47.1 to 19.53.0 (also happens in 20.0.8). My guess is that it has something to do with the Golang icon refactor that was done around the same time.

I created a Gist with the debug build output (from 20.0.8) and highlighted what I think are the relevant lines: https://gist.github.com/gschier/34d7757010e4908e16ad8cad9facc9a7#file-electron-builder-debug-txt-L121-L125

It seems like it's not even trying to locate /home/gschier/Desktop/sf_insomnia/packages/insomnia-app/build/icon.icns and falling back to the default Electron icons.

Thoughts? Let me know if there's anything else I can provide.

develar added a commit to develar/electron-builder that referenced this issue Feb 23, 2018
@gschier
Copy link
Author

gschier commented Feb 23, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants