-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Signing for Windows 10 hangs in 18.8.1 - With workaround #1735
Closed
Comments
logidelic
changed the title
Signing for Windows 10 hangs in most recent 18.8.1 - With workaround
Signing for Windows 10 hangs in 18.8.1 - With workaround
Jun 22, 2017
Why closed? |
I had used npm upgrade which updated me to 18.8.1 so I thought that was the latest release, but I see in your releases that there are much newer releases, so I'm trying with the latest (19.6.3) as I type this... |
Nope, it is serious regression. |
develar
pushed a commit
to develar/electron-builder
that referenced
this issue
Jun 22, 2017
develar
pushed a commit
to develar/electron-builder
that referenced
this issue
Jun 22, 2017
develar
pushed a commit
to develar/electron-builder
that referenced
this issue
Jun 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I recently upgraded to electron-builder 18.8.1. Previously I was using 18.5.1 and signing was working correctly. Without any changes other than the upgrade to 18.8.1, I noticed that when building the installer, the process would hang at:
Signing CorpApp.exe (certificate file: "c:\Users\user\dev\corp\apps\certs\corp_code.p12")
Looking at the hung process I saw that it was trying to execute:
powershell.exe "(Get-PfxCertificate \"c:\Users\user\dev\corp\apps\certs\corp_code.p12\").Subject"
When I tried to execute this step manually I noticed that it was prompting me for a password. I tried to type in my certificate password where the electron-builder script was hung, and sure enough, that allowed the script to continue.
My password is specified correctly in the CSC_KEY_PASSWORD environment variable (and was working with 18.5.1)...
The text was updated successfully, but these errors were encountered: