Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppImage artifact name does not use artifactName template #1726

Closed
p120ph37 opened this issue Jun 22, 2017 · 3 comments · May be fixed by qcif/data-curator#563
Closed

AppImage artifact name does not use artifactName template #1726

p120ph37 opened this issue Jun 22, 2017 · 3 comments · May be fixed by qcif/data-curator#563
Assignees

Comments

@p120ph37
Copy link
Contributor

  • Version: 19.6.0
  • Target: AppImage

The AppImage target uses the computeSafeArtifactName method to generate the output artifact name. This method uses a hard-coded template string of "${name}-${version}-${arch}.${ext}" rather than using the configured artifactName from package.json.

@develar
Copy link
Member

develar commented Jun 22, 2017

Yeah, it is what I don't want do because it violates Linux convention. Ok.... #775

@develar develar self-assigned this Jun 22, 2017
develar added a commit to develar/electron-builder that referenced this issue Jun 22, 2017
@p120ph37
Copy link
Contributor Author

My artifactName template is set to ${name}-${version}.${ext}, so it doesn't suffer the spaces-in-name bug. One possible (drastic) solution would be to change the top-level default value to ${name}-${version}-${arch}.${ext}, but allow overrides. Another possible solution would be to have a localized artifactName parameter that does not inherit from the global default, and can be overriding within the pkg target config.

@develar
Copy link
Member

develar commented Jun 22, 2017

Fixed in 19.7.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants