Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no commit task #1577

Closed
black-snow opened this issue May 23, 2017 · 1 comment
Closed

no commit task #1577

black-snow opened this issue May 23, 2017 · 1 comment
Labels
readme improvement

Comments

@black-snow
Copy link
Contributor

  • Version: 17.10.0
  • Target: -

CONTRIBUTING.md says:

run npm run commit in your terminal after staging your changes in git.

But there ain't no such task in package.json.
I installed commitizen npm i -g commitizen and ran git cz but that just made a normal commit.
@develar
Copy link
Member

develar commented May 23, 2017

Incorrect sentence removed. In any case PR will be squashed and commit messages reformatted if need. Contributor should not worry about it.

develar added a commit to develar/electron-builder that referenced this issue May 23, 2017
@develar
refactor(updater): prepare to support private github repo, nuts and s…
3aae466 
…o on on macOS

BREAKING CHANGE: remove compatibility with very old electron-updater version (< 0.10.0)

Close electron-userland#1575, Close electron-userland#1571, Close electron-userland#1577
@dependabot-preview dependabot-preview bot mentioned this issue Mar 14, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
readme improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@develar @black-snow