-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NSIS perMachine false and allowToChangeInstallationDirectory #1104
Comments
Only oneClick is required to be set to false. PerMachine, AFAIK, must be supported. I will check it again. |
I've gathered some more information. Still not sure if it's a NSIS issue or an electron-builder issue. Results in no directory change screen. Which is not expected behavior:
Results in a directory change screen but no ability to select For Me or All Users. This works as I expect it to:
Results in a directory change screen and the ability to select For Me or All Users but has to be manually run as admin:
The last configuration there is closest to expected behavior but you shouldn't have to exclude allowElevation to get it to work correctly, in my opinion. Additionally if you use the last config there and don't run it as admin, the default selection is For All Users which obviously fails. Which isn't a big deal, that just shouldn't be the default selection since it's disabled. |
I tried all the combinations mentioned by ZedTheYeti but I can't make the directory change screen appear.
|
…hes /^[-_0-9a-zA-Z ]+$/ BREAKING CHANGE: installation path change Close electron-userland#1100, electron-userland#767, electron-userland#1104
From my testing setting
perMachine
to false (or leaving it default) and settingallowToChangeInstallationDirectory
to true do not work together. IfperMachine
is false then the installation directory page is bypassed. IfperMachine
is set to true then it's displayed. Is this intentional functionality or maybe a limitation of NSIS? I've looked through the source for electron-builder and I can't find anything that would specifically preclude the two from working together.The text was updated successfully, but these errors were encountered: