Skip to content

Commit

Permalink
feat: dual code-sign windows app + timestamped
Browse files Browse the repository at this point in the history
  • Loading branch information
develar committed May 11, 2016
1 parent b5505fc commit b71d2f3
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
2 changes: 1 addition & 1 deletion docs/Code Signing.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
OS X and Windows code singing is supported.
OS X and Windows code signing is supported. Windows is dual code-signed (SHA1 & SHA256 hashing algorithms).

On a development machine set environment variable `CSC_NAME` (and `CSC_INSTALLER_NAME` if you build for Mac App Store) to your identity.

Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@
"deep-assign": "^2.0.0",
"electron-osx-sign-tf": "0.4.0-beta.0",
"electron-packager-tf": "^7.0.2-beta.0",
"electron-winstaller-fixed": "~2.5.0",
"electron-winstaller-fixed": "~2.6.2",
"fs-extra-p": "^1.0.1",
"globby": "^4.0.0",
"hosted-git-info": "^2.1.4",
Expand All @@ -76,7 +76,7 @@
"progress": "^1.1.8",
"progress-stream": "^1.2.0",
"read-package-json": "^2.0.4",
"signcode-tf": "^0.5.0",
"signcode-tf": "^0.6.3",
"source-map-support": "^0.4.0",
"tmp": "0.0.28"
},
Expand Down
4 changes: 1 addition & 3 deletions src/winPackager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ export class WinPackager extends PlatformPackager<WinBuildOptions> {
protected async packApp(options: any, appOutDir: string) {
await super.packApp(options, appOutDir)

if (process.platform === "darwin" && this.options.cscLink != null && this.options.cscKeyPassword != null) {
if (process.platform !== "linux" && this.options.cscLink != null && this.options.cscKeyPassword != null) {
const filename = this.appName + ".exe"
log(`Signing ${filename}`)
await BluebirdPromise.promisify(sign)({
Expand All @@ -97,7 +97,6 @@ export class WinPackager extends PlatformPackager<WinBuildOptions> {
password: this.options.cscKeyPassword,
name: this.appName,
site: await this.computePackageUrl(),
hash: ["sha256"],
overwrite: true,
})
}
Expand Down Expand Up @@ -144,7 +143,6 @@ export class WinPackager extends PlatformPackager<WinBuildOptions> {
sign: {
name: this.appName,
site: projectUrl,
hash: ["sha256"],
overwrite: true,
}
}, this.customBuildOptions)
Expand Down

0 comments on commit b71d2f3

Please sign in to comment.