fix: Asar: false, causing exception on app startup with v16.4.0

Close #1409
electron-userland · Mar 27, 2017 · 7c6b4ab · 7c6b4ab
1 parent 0278efb
commit 7c6b4ab
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/packages/electron-builder-util/src/fs.ts b/packages/electron-builder-util/src/fs.ts
@@ -174,8 +174,11 @@ export class FileCopier {
           if (typeof (<any>data).then === "function") {
             data = await data
           }
-          await writeFile(dest, data)
-          return
+
+          if (data != null) {
+            await writeFile(dest, data)
+            return
+          }
         }
       }
       await copyFile(src, dest, stat, (!this.isUseHardLink || this.isUseHardLinkFunction == null) ? this.isUseHardLink : this.isUseHardLinkFunction(dest))

diff --git a/packages/electron-builder/src/platformPackager.ts b/packages/electron-builder/src/platformPackager.ts
@@ -176,7 +176,7 @@ export abstract class PlatformPackager<DC extends PlatformSpecificBuildOptions>
     }
 
     const defaultMatcher = createFileMatcher(this.info, appDir, resourcesPath, macroExpander, platformSpecificBuildOptions)
-    const isElectronCompile = isElectronCompileUsed(this.info)
+    const isElectronCompile = asarOptions != null && isElectronCompileUsed(this.info)
     if (isElectronCompile) {
       defaultMatcher.addPattern("!.cache{,/**/*}")
     }