Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove iOS container #67

Merged
merged 3 commits into from
Jan 11, 2020
Merged

remove iOS container #67

merged 3 commits into from
Jan 11, 2020

Conversation

liulianci
Copy link
Contributor

added a script to create container. run ./ios/createContainer.sh to get iOS container

@liulianci liulianci force-pushed the scriptToAddContainer branch from 972c741 to 174c98a Compare January 2, 2020 19:03
friederbluemle
friederbluemle reviewed Jan 2, 2020
View reviewed changes
Copy link
Member

@friederbluemle friederbluemle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 👍

The new script does not show up in the diff (too many changes). Can you please either use two separate commits, or just paste the script to the PR description for review?

.gitignore Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@liulianci liulianci force-pushed the scriptToAddContainer branch from 174c98a to 4a65637 Compare January 2, 2020 22:18
@deepueg
Copy link
Contributor

deepueg commented Jan 6, 2020

Thanks @liulianci

@liulianci liulianci force-pushed the scriptToAddContainer branch 5 times, most recently from 057fd1f to 044d0f6 Compare January 10, 2020 21:10
@liulianci
Copy link
Contributor Author

This is part of PR #60

@liulianci liulianci force-pushed the scriptToAddContainer branch from 044d0f6 to d0a6e2c Compare January 10, 2020 21:13
@liulianci
add ElectrodeContainer to Embed Frameworks
5f5a573 
add ElectrodeContainer to embed frameworks to fix a crash on Device:
dyld: Library not loaded: @rpath/ElectrodeContainer.framework/ElectrodeContainer
friederbluemle
friederbluemle approved these changes Jan 11, 2020
View reviewed changes
Copy link
Member

@friederbluemle friederbluemle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@liulianci liulianci merged commit 9cc9499 into electrode-io:master Jan 11, 2020
@liulianci liulianci deleted the scriptToAddContainer branch January 11, 2020 00:46
@friederbluemle friederbluemle mentioned this pull request Jan 11, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friederbluemle friederbluemle friederbluemle approved these changes

@deepueg deepueg Awaiting requested review from deepueg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liulianci @deepueg @friederbluemle