Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use xcode 12.0 #189

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

use xcode 12.0 #189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10ab06f
use xcode 12.0
liulianci Jul 28, 2021
42402e6
update
liulianci Jul 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ jobs:
- uses: actions/setup-node@v1
with:
node-version: '12'
xcode-version: '12.0'
Copy link
Member

@friederbluemle friederbluemle Jul 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you intend to use the setup-xcode action here? Right now it's part of setup-node.

What we probably need is this:

- uses: maxim-lobanov/setup-xcode@v1
  with:
    xcode-version: '12.0'

I've added it to the existing workflow update PR #186, please confirm if that looks good. Also please confirm that we do need 12.0 here, and why. Interestingly they don't list 12.0 (but 12.0.1) for macos-latest (which is currently macOS 10.15).

See list of available versions here: https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.15-Readme.md#xcode

- run: npm i -g electrode-native
- run: yarn --frozen-lockfile
- working-directory: ios/
Expand Down
2 changes: 1 addition & 1 deletion ios/ElectrodeApiImpl/Libraries/ReactNative/React/CxxBridge/RCTCxxBridge.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,7 +743,7 @@ - (void)registerExtraLazyModules
#endif
}

- (NSArray<RCTModuleData *> *)_initializeModules:(NSArray<id<RCTBridgeModule>> *)modules
- (NSArray<RCTModuleData *> *)_initializeModules:(NSArray<Class> *)modules
withDispatchGroup:(dispatch_group_t)dispatchGroup
lazilyDiscovered:(BOOL)lazilyDiscovered
{
Expand Down