[minor][chore] Update component generator #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didi0613
changed the title
jchip
reviewed
Jul 6, 2017
| @@ -181,6 +182,15 @@ var ReactComponentGenerator = yeoman.Base.extend({ | |||
| this.template("packages/component/_readme.md", this.rootPath + "README.md"); | |||
| }, | |||
| component: function() { | |||
| let getDemoFilePath = function(filepath) { | |||
| try { | |||
There was a problem hiding this comment.
@jchip If the filepath does not exists, it will throw the error similar to below.
Scenario:
demo-helper version <@2.1.0 and if it is trying to copy demo folder:
events.js:160
throw er; // Unhandled 'error' event
^
AssertionError: Trying to copy from a source that does not exist: /Users/s0d00px/electrode/packages/generator-electrode/node_modules/electrode-demo-helper/demo
at EditionInterface.exports._copySingle (/Users/s0d00px/electrode/packages/generator-electrode/node_modules/yeoman-generator/node_modules/mem-fs-editor/lib/actions/copy.js:45:3)
at EditionInterface.exports.copy (/Users/s0d00px/electrode/packages/generator-electrode/node_modules/yeoman-generator/node_modules/mem-fs-editor/lib/actions/copy.js:23:17)
at EditionInterface.module.exports [as copyTpl] (/Users/s0d00px/electrode/packages/generator-electrode/node_modules/yeoman-generator/node_modules/mem-fs-editor/lib/actions/copy-tpl.js:10:8)
at constructor.component (/Users/s0d00px/electrode/packages/generator-electrode/component/index.js:210:15)
at Object.<anonymous> (/Users/s0d00px/electrode/packages/generator-electrode/node_modules/yeoman-generator/lib/base.js:431:23)
at /Users/s0d00px/electrode/packages/generator-electrode/node_modules/yeoman-generator/node_modules/run-async/index.js:25:25
at /Users/s0d00px/electrode/packages/generator-electrode/node_modules/yeoman-generator/node_modules/run-async/index.js:24:19
at /Users/s0d00px/electrode/packages/generator-electrode/node_modules/yeoman-generator/lib/base.js:432:9
at runCallback (timers.js:672:20)
at tryOnImmediate (timers.js:645:5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update component generator with demo folder
Tested locally on component & component-add