peer review. incorporated comments #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
raydecastro
commented
Sep 7, 2016
•
raydecastro
commented
- minor text changes
- removed export
- added 9/7 meeting changes
- changed name to electrode-boilerplate-app
raydecastro
changed the title
|
|
||
| - Confippet is built-in to electrode. | ||
| ## Electrode Confippet | ||
| - Confippet is a standalone module that can be used w/o other parts of electrode |
There was a problem hiding this comment.
Confippet is a versatile utility for managing your NodeJS application configuration. Its goal is customization and extensibility, but offers a preset config out of the box.
also add a link to https://github.com/electrode-io/electrode-confippet here
There was a problem hiding this comment.
@ananavati incorporated changes and renamed repo
|
LGTM after the markdown link |
ananavati
pushed a commit
that referenced
this pull request
Nov 26, 2016
* Basic manifest.json and ServiceWorker support * Remove extra SW registration script, change marker Marker name changed so its consistent with the others * Remove unused report.txt file This was just a temp. thing so I could read through the output of a console.log call that was super long * Linting fixes * Add 144x144 icon for web app install banner * Inject meta tags from iconstats.json iconstats.json is generated by favicon-webpack-plugin and includes a manifest.json file. It contains all of the required icon assets, so all we have to add is add the /js path so they resolve correctly. Remove sw.js file This was the result of an incorrect path for the build and should not be tracked * Remove generated stats files * Remove unused service worker registration file This will now be included in the client source and parses from the webpack assets. * Create service worker registration module This file will be required using require.ensure so that it compiles to its own file, for caching. It exports a function that must be called to trigger the registration. The function accepts a callback that will be called when the registration object is available. Initially this used promises, but that caused the file size to go up a lot since webpack was included polyfills for Promise + friends. * Remove SW registration injection from webapp This is handled by webpack now * Return original paths from iconStats We don't need to replace the path in the meta tags anymore since we're specifying publicPath in the archetype now * Remove build artifacts * Add demo page for push notifications * Use sw-config.js for all PWA configuration * Remove unused register-sw.html file * move js bundle to body * Remove unused REGISTER_SW marker * Return early if serviceWorker is not supported * Add cURL command + more to push demo The demo now has a curl command you can copy + pase into your shell to send a push notification to the client! The demo will now also tell you if SW is not supported, or if you're not subscribed to notifications yet. * Use arrow function with requre.ensure Because we can! * Rewrite service worker registration file * Add real gcm_sender_id from firebase This way we can send notifications from a remote endpoint * Add meta tag for viewport (#2) * add meta tag for viewport * use decimal for scale * Do not precache app icons App icons should not be precached since they are client-specific, and no one client will be requesting all of them. Precaching them all just increases our total bytes transferred * Use importScripts to extend service worker This depends on work done in the archetype. It will parse the paths in importScripts and create an entry point for each, then sw-precache will import them directly. This supports importing an arbitrary number of scripts from any location in the client folder * Fix curl command output in push demo * Add icon and badge to push notifications * Error handling for push notification demo
jchip
pushed a commit
that referenced
this pull request
Dec 7, 2016
* review. incorporated peer review comments. * docs. added meeting changes. * docs. minor sections changes + titles. * docs. updated name + package.json info. * review. added text changes. * review. added confippet link in markdown
jchip
pushed a commit
that referenced
this pull request
Dec 7, 2016
Unify the configs for manifest and runtime caching.
jchip
pushed a commit
that referenced
this pull request
Dec 7, 2016
* Basic manifest.json and ServiceWorker support * Remove extra SW registration script, change marker Marker name changed so its consistent with the others * Remove unused report.txt file This was just a temp. thing so I could read through the output of a console.log call that was super long * Linting fixes * Add 144x144 icon for web app install banner * Inject meta tags from iconstats.json iconstats.json is generated by favicon-webpack-plugin and includes a manifest.json file. It contains all of the required icon assets, so all we have to add is add the /js path so they resolve correctly. Remove sw.js file This was the result of an incorrect path for the build and should not be tracked * Remove generated stats files * Remove unused service worker registration file This will now be included in the client source and parses from the webpack assets. * Create service worker registration module This file will be required using require.ensure so that it compiles to its own file, for caching. It exports a function that must be called to trigger the registration. The function accepts a callback that will be called when the registration object is available. Initially this used promises, but that caused the file size to go up a lot since webpack was included polyfills for Promise + friends. * Remove SW registration injection from webapp This is handled by webpack now * Return original paths from iconStats We don't need to replace the path in the meta tags anymore since we're specifying publicPath in the archetype now * Remove build artifacts * Add demo page for push notifications * Use sw-config.js for all PWA configuration * Remove unused register-sw.html file * move js bundle to body * Remove unused REGISTER_SW marker * Return early if serviceWorker is not supported * Add cURL command + more to push demo The demo now has a curl command you can copy + pase into your shell to send a push notification to the client! The demo will now also tell you if SW is not supported, or if you're not subscribed to notifications yet. * Use arrow function with requre.ensure Because we can! * Rewrite service worker registration file * Add real gcm_sender_id from firebase This way we can send notifications from a remote endpoint * Add meta tag for viewport (#2) * add meta tag for viewport * use decimal for scale * Do not precache app icons App icons should not be precached since they are client-specific, and no one client will be requesting all of them. Precaching them all just increases our total bytes transferred * Use importScripts to extend service worker This depends on work done in the archetype. It will parse the paths in importScripts and create an entry point for each, then sw-precache will import them directly. This supports importing an arbitrary number of scripts from any location in the client folder * Fix curl command output in push demo * Add icon and badge to push notifications * Error handling for push notification demo
jchip
added a commit
that referenced
this pull request
Dec 9, 2016
jchip
pushed a commit
that referenced
this pull request
Dec 15, 2016
* remove electrode-demo-index and move it under archetype
jchip
pushed a commit
to jchip/electrode
that referenced
this pull request
Dec 15, 2016
fix correct anchor link location
jchip
added a commit
to jchip/electrode
that referenced
this pull request
Mar 16, 2017
Adds Team Electrode link to readme.md
didi0613
added a commit
to didi0613/electrode
that referenced
this pull request
Jun 20, 2017
# This is the 1st commit message: update travis # The commit message electrode-io#2 will be skipped: # add traivs env # The commit message electrode-io#3 will be skipped: # add traivs env
didi0613
added a commit
to didi0613/electrode
that referenced
this pull request
Jun 28, 2017
# This is the 1st commit message: add xclai-cli to archetype app # The commit message electrode-io#2 will be skipped: # update docs from training # The commit message electrode-io#3 will be skipped: # fixes
didi0613
added a commit
to didi0613/electrode
that referenced
this pull request
Aug 1, 2017
# This is the 1st commit message: # This is a combination of 2 commits. # This is the 1st commit message: update component add gerator docs (electrode-io#512) # The commit message electrode-io#2 will be skipped: # Add chrome headless to component archetype # The commit message electrode-io#2 will be skipped: # code review
didi0613
added a commit
to didi0613/electrode
that referenced
this pull request
Aug 8, 2017
# This is the 1st commit message: Update component archetype readme # The commit message electrode-io#2 will be skipped: # update archetype component readme # The commit message electrode-io#3 will be skipped: # update electrode component readme # The commit message electrode-io#4 will be skipped: # update electrode component readme
didi0613
added a commit
to didi0613/electrode
that referenced
this pull request
Aug 8, 2017
# This is the 1st commit message: Update component archetype readme # The commit message electrode-io#2 will be skipped: # update electrode component readme
didi0613
added a commit
to didi0613/electrode
that referenced
this pull request
Aug 8, 2017
# This is the 1st commit message: Update component archetype readme # The commit message electrode-io#2 will be skipped: # # This is a combination of 2 commits. # # This is the 1st commit message: # # Update component archetype readme # # # The commit message electrode-io#2 will be skipped: # # # update electrode component readme
didi0613
added a commit
to didi0613/electrode
that referenced
this pull request
Aug 10, 2017
# This is the 1st commit message: update component readme generated by electrode-generator # The commit message electrode-io#2 will be skipped: # update component readme generated by electrode-generator
jchip
pushed a commit
that referenced
this pull request
Aug 14, 2017
* # This is a combination of 2 commits. # This is the 1st commit message: Update component archetype readme # The commit message #2 will be skipped: # # This is a combination of 2 commits. # # This is the 1st commit message: # # Update component archetype readme # # # The commit message #2 will be skipped: # # # update electrode component readme * code review * code review readme
didi0613
added a commit
to didi0613/electrode
that referenced
this pull request
Oct 18, 2017
# This is the 1st commit message: Update for wml electrode-ignite # The commit message electrode-io#2 will be skipped: # Pass link as params for electrode official docs of both oss and internal
didi0613
added a commit
to didi0613/electrode
that referenced
this pull request
Nov 15, 2017
# This is the 1st commit message: enable defer based on latest css-split-webpack-plugin # The commit message electrode-io#2 will be skipped: # defer archetype app css split
datvong-wm
pushed a commit
to datvong-wm/electrode
that referenced
this pull request
Sep 5, 2018
add .eslintrc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.