Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: merge changes from master and fix poc-subapp #1919

Conversation

arunvishnun
Copy link
Contributor

@arunvishnun arunvishnun commented Dec 5, 2022

  • Merging changes from master.
  • Make poc-subapp (sample application) running with rushjs tooling.
  • Remove bluebird reference from sample app and switch to use native promise.
  • Switch to use xrun instead of clap in poc-subapp and remove fyn references

How to run sample app

Run below commands

  • rush install. Run rush update if you like to recreate pnpm-lock.json. More details here
  • rush build
  • cd samples/poc-subapp && rushx dev (rushx dev is analogous to previous fun dev command).

How to work on sample apps for testing package changes in the repo

  • Rush links packages internally, similar to npm link. So we can work on internal dependencies to test the changes without actually publishing packages/*.

@CLAassistant
Copy link

CLAassistant commented Dec 5, 2022

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
4 out of 5 committers have signed the CLA.

✅ ashuverma
✅ SRHerzog
✅ arunvishnun
✅ mristic505
❌ srinathm85
You have signed the CLA already but the status is still pending? Let us recheck it.

@arunvishnun arunvishnun marked this pull request as ready for review December 6, 2022 18:07
@arunvishnun arunvishnun merged commit ae5a6ce into electrode-io:rush-pnpm-migration Dec 28, 2022
arunvishnun added a commit to arunvishnun/electrode that referenced this pull request Jan 20, 2023
* add two options for improving webpack performance (electrode-io#1904)

Co-authored-by: Steve Herzog <[email protected]>

* feature: open browser when proxy is ready (electrode-io#1905)

Co-authored-by: Steve Herzog <[email protected]>

* Fix broken reporter link (electrode-io#1908)

* Update changelog

* [Publish]

 - @xarc/[email protected]
 - @xarc/[email protected]
 - @xarc/[email protected]

* Upgrade poc-subapp and poc-subapp-redux to react18 with rr6 (electrode-io#1913)

* Upgrade POC-SUBAPP-REDUX to React 18 and RR6

* Upgrade poc-subapp to react 16 and RR6

* fix types issues in multiple packages (electrode-io#1918)

* fix types issues in multiple packages

Co-authored-by: Arun Vishnu <[email protected]>

* fix: poc-subapp and merge changes from master

* fix: update devtool to use eval-cheap-module-source-map

* chore: remove debug statement

Co-authored-by: Steve Herzog <[email protected]>
Co-authored-by: Steve Herzog <[email protected]>
Co-authored-by: Ashu Verma <[email protected]>
Co-authored-by: smuthya <[email protected]>
Co-authored-by: mristic505 <[email protected]>
Co-authored-by: Arun Vishnu <[email protected]>
arunvishnun added a commit to arunvishnun/electrode that referenced this pull request Mar 21, 2023
* add two options for improving webpack performance (electrode-io#1904)

Co-authored-by: Steve Herzog <[email protected]>

* feature: open browser when proxy is ready (electrode-io#1905)

Co-authored-by: Steve Herzog <[email protected]>

* Fix broken reporter link (electrode-io#1908)

* Update changelog

* [Publish]

 - @xarc/[email protected]
 - @xarc/[email protected]
 - @xarc/[email protected]

* Upgrade poc-subapp and poc-subapp-redux to react18 with rr6 (electrode-io#1913)

* Upgrade POC-SUBAPP-REDUX to React 18 and RR6

* Upgrade poc-subapp to react 16 and RR6

* fix types issues in multiple packages (electrode-io#1918)

* fix types issues in multiple packages

Co-authored-by: Arun Vishnu <[email protected]>

* fix: poc-subapp and merge changes from master

* fix: update devtool to use eval-cheap-module-source-map

* chore: remove debug statement

Co-authored-by: Steve Herzog <[email protected]>
Co-authored-by: Steve Herzog <[email protected]>
Co-authored-by: Ashu Verma <[email protected]>
Co-authored-by: smuthya <[email protected]>
Co-authored-by: mristic505 <[email protected]>
Co-authored-by: Arun Vishnu <[email protected]>
arunvishnun added a commit to arunvishnun/electrode that referenced this pull request Mar 22, 2023
* add two options for improving webpack performance (electrode-io#1904)

Co-authored-by: Steve Herzog <[email protected]>

* feature: open browser when proxy is ready (electrode-io#1905)

Co-authored-by: Steve Herzog <[email protected]>

* Fix broken reporter link (electrode-io#1908)

* Update changelog

* [Publish]

 - @xarc/[email protected]
 - @xarc/[email protected]
 - @xarc/[email protected]

* Upgrade poc-subapp and poc-subapp-redux to react18 with rr6 (electrode-io#1913)

* Upgrade POC-SUBAPP-REDUX to React 18 and RR6

* Upgrade poc-subapp to react 16 and RR6

* fix types issues in multiple packages (electrode-io#1918)

* fix types issues in multiple packages

Co-authored-by: Arun Vishnu <[email protected]>

* fix: poc-subapp and merge changes from master

* fix: update devtool to use eval-cheap-module-source-map

* chore: remove debug statement

Co-authored-by: Steve Herzog <[email protected]>
Co-authored-by: Steve Herzog <[email protected]>
Co-authored-by: Ashu Verma <[email protected]>
Co-authored-by: smuthya <[email protected]>
Co-authored-by: mristic505 <[email protected]>
Co-authored-by: Arun Vishnu <[email protected]>
arunvishnun added a commit to arunvishnun/electrode that referenced this pull request Mar 24, 2023
* add two options for improving webpack performance (electrode-io#1904)

Co-authored-by: Steve Herzog <[email protected]>

* feature: open browser when proxy is ready (electrode-io#1905)

Co-authored-by: Steve Herzog <[email protected]>

* Fix broken reporter link (electrode-io#1908)

* Update changelog

* [Publish]

 - @xarc/[email protected]
 - @xarc/[email protected]
 - @xarc/[email protected]

* Upgrade poc-subapp and poc-subapp-redux to react18 with rr6 (electrode-io#1913)

* Upgrade POC-SUBAPP-REDUX to React 18 and RR6

* Upgrade poc-subapp to react 16 and RR6

* fix types issues in multiple packages (electrode-io#1918)

* fix types issues in multiple packages

Co-authored-by: Arun Vishnu <[email protected]>

* fix: poc-subapp and merge changes from master

* fix: update devtool to use eval-cheap-module-source-map

* chore: remove debug statement

Co-authored-by: Steve Herzog <[email protected]>
Co-authored-by: Steve Herzog <[email protected]>
Co-authored-by: Ashu Verma <[email protected]>
Co-authored-by: smuthya <[email protected]>
Co-authored-by: mristic505 <[email protected]>
Co-authored-by: Arun Vishnu <[email protected]>
arunvishnun added a commit to arunvishnun/electrode that referenced this pull request Mar 24, 2023
* add two options for improving webpack performance (electrode-io#1904)

Co-authored-by: Steve Herzog <[email protected]>

* feature: open browser when proxy is ready (electrode-io#1905)

Co-authored-by: Steve Herzog <[email protected]>

* Fix broken reporter link (electrode-io#1908)

* Update changelog

* [Publish]

 - @xarc/[email protected]
 - @xarc/[email protected]
 - @xarc/[email protected]

* Upgrade poc-subapp and poc-subapp-redux to react18 with rr6 (electrode-io#1913)

* Upgrade POC-SUBAPP-REDUX to React 18 and RR6

* Upgrade poc-subapp to react 16 and RR6

* fix types issues in multiple packages (electrode-io#1918)

* fix types issues in multiple packages

Co-authored-by: Arun Vishnu <[email protected]>

* fix: poc-subapp and merge changes from master

* fix: update devtool to use eval-cheap-module-source-map

* chore: remove debug statement

Co-authored-by: Steve Herzog <[email protected]>
Co-authored-by: Steve Herzog <[email protected]>
Co-authored-by: Ashu Verma <[email protected]>
Co-authored-by: smuthya <[email protected]>
Co-authored-by: mristic505 <[email protected]>
Co-authored-by: Arun Vishnu <[email protected]>
arunvishnun added a commit that referenced this pull request Mar 28, 2023
* [WIP] Use rush + pnpm for managing monorepo (#1907)

* Add rush config files

* Add few projects for testing install and build

 Author:    Ashu Verma <[email protected]>

* Update Github Workflow to use rush

* Add all the packages and fix dependencies

Include All the packages in the repo into rush.
Fix missing build scripts.
Add missing dependencies.

* Enabling tests. All of them still don't work

* add node 16 in ci (#1901)

* add node 16 in ci

* [fix]: upgrade xarc-opt-sass to pass node 16 build (#1902)

Co-authored-by: Srinath Muthyala <[email protected]>
Co-authored-by: mristic505 <[email protected]>

* Update github action and fix tests (#1910)

* Update github action and adding in several test fixes with rush

Co-authored-by: Arun Vishnu <[email protected]>

* feat: merge changes from master and fix poc-subapp (#1919)

* add two options for improving webpack performance (#1904)

Co-authored-by: Steve Herzog <[email protected]>

* feature: open browser when proxy is ready (#1905)

Co-authored-by: Steve Herzog <[email protected]>

* Fix broken reporter link (#1908)

* Update changelog

* [Publish]

 - @xarc/[email protected]
 - @xarc/[email protected]
 - @xarc/[email protected]

* Upgrade poc-subapp and poc-subapp-redux to react18 with rr6 (#1913)

* Upgrade POC-SUBAPP-REDUX to React 18 and RR6

* Upgrade poc-subapp to react 16 and RR6

* fix types issues in multiple packages (#1918)

* fix types issues in multiple packages

Co-authored-by: Arun Vishnu <[email protected]>

* fix: poc-subapp and merge changes from master

* fix: update devtool to use eval-cheap-module-source-map

* chore: remove debug statement

Co-authored-by: Steve Herzog <[email protected]>
Co-authored-by: Steve Herzog <[email protected]>
Co-authored-by: Ashu Verma <[email protected]>
Co-authored-by: smuthya <[email protected]>
Co-authored-by: mristic505 <[email protected]>
Co-authored-by: Arun Vishnu <[email protected]>

* fix poc subapp redux when running with rushx (#1920)

* Upgrade poc-subapp and poc-subapp-redux to react18 with rr6 (#1913)

* Upgrade POC-SUBAPP-REDUX to React 18 and RR6

* Upgrade poc-subapp to react 16 and RR6

* fix types issues in multiple packages (#1918)

* fix types issues in multiple packages

Co-authored-by: Arun Vishnu <[email protected]>

* fix: sample app - poc-subapp-redux

* chore: pnpm-lock updated

* fix: incorrect filename reference in the import statement

* fix: incorrect filename reference in the import statement

Co-authored-by: mristic505 <[email protected]>
Co-authored-by: Arun Vishnu <[email protected]>

* feat: add commitlint configs (#1921)

* docs: documentation updates (#1922)

* docs: update readme and contribution guidelines

* docs: documentation and contribution guidelines updated

* docs: update release guidelines

* docs: update release guidelines

* chore: testing package publish flow (#1925)

* fix: update message log

* fix: update message log

* fix: update message log

* cleanup (#1927)

* fix: publish flow

* fix: clean up

* rush test publish package (#1928)

* feat: message update - test rush publish

* feat: message update - test rush publish

* chore: bump versions [skip ci] (#1929)

* developer flow - change file creation - test (#1930)

* feat: message update - test rush publish

* chore: rush change commit

* chore: delete test packages created to test publish flow with rush (#1931)

* docs: update package publishing process with rush (#1933)

* Publishtest (#7)

* feat: add a new test package for publish test

* chore: new package to test publish operation - commiting change files

* chore: bump versions [skip ci]

* docs: update package publishing process with rush

* chore: remove unused files

* chore: remove unused files

* chore: update shrinkwrap file

* docs: update documentation with commitlint details (#1934)

* docs: update documentation with commitlint details

* feat: rebase rush changes with master

* docs: update documentations

* fix: webpack version inconsistency issues

* chore: enable temporarly commented lines in rush branch

* chore: uncommenting a test case  and un necessary console.log

* chore: use rever to use clap keep minimal changes against master branch

* chore: use mocha config same as master branch

* chore: changelog jsons from rush change

* fix: types error in xarc-app-dev package (#8)

* fix: types error in xarc-app-dev package

* docs: update to contribution guidelines

* docs: update to contribution guidelines

* fix: eslint issues in sample apps (#9)

* fix: test issues in sample apps (#10)

* fix: test issues in sample apps

* fix: test issues in sample apps

* chore: allow warnings in successful builds (#11)

* fix: test issues in sample apps

* fix: test issues in sample apps

* chore: allow warnings in successful builds

* chore: allow warnings in successful builds

* fix: tests for node 12 (#12)

* fix: test issues in sample apps

* fix: test issues in sample apps

* fix: tests for node 12

* test: fix unit test failing in subapp-web@2

* chore: update pnpm lock file

* chore: add ci step to verify changelogs available

* chore: add ci step to verify changelogs available

* chore: add ci step to verify changelogs available

---------

Co-authored-by: Ashu Verma <[email protected]>
Co-authored-by: Srinath Muthyala <[email protected]>
Co-authored-by: Srinath Muthyala <[email protected]>
Co-authored-by: mristic505 <[email protected]>
Co-authored-by: Arun Vishnu <[email protected]>
Co-authored-by: Steve Herzog <[email protected]>
Co-authored-by: Steve Herzog <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants