Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add unit test, fix lint errors and warnings for subapp #1826

Merged
merged 3 commits into from
Feb 18, 2021

Conversation

zenz34
Copy link
Contributor

@zenz34 zenz34 commented Feb 18, 2021

can't use delete in strict mode, so leave _clearContainer inside node/index.ts for now.
let me know If there's a better way. Thanks in advance!

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jchip jchip merged commit a822107 into electrode-io:master Feb 18, 2021
@zenz34 zenz34 deleted the unit-test-subapp branch March 10, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants