Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unit test error after redux code changes #1821

Merged
merged 1 commit into from
Feb 12, 2021

Conversation

zenz34
Copy link
Contributor

@zenz34 zenz34 commented Feb 11, 2021

fix unit test error after redux code changes, covered 100% lines

------------------------|---------|----------|---------|---------|-------------------

File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 98.48 94.74 67.65 100
browser 100 100 100 100
index.tsx 100 100 100 100
common 98.45 94.74 67.65 100
index.tsx 98.31 89.29 44.44 100 173,180-187
redux-shared-store.ts 98.57 100 93.75 100
node 0 0 0 0
index.ts 0 0 0 0
------------------------ --------- ---------- --------- --------- -------------------

=============================== Coverage summary ===============================
Statements : 98.48% ( 130/132 )
Branches : 94.74% ( 54/57 )
Functions : 67.65% ( 23/34 )
Lines : 100% ( 116/116 )

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jchip jchip merged commit 717d877 into electrode-io:master Feb 12, 2021
@zenz34 zenz34 deleted the fix-redux-decorator-unit-test branch March 10, 2021 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants