Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ui config to route options #1748

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Conversation

divyakarippath
Copy link
Contributor

@divyakarippath divyakarippath commented Oct 20, 2020

Fixes https://jira.walmart.com/browse/CEECORE-2000

Basepath was not getting updated in @walmart/electrode-ui-config which was causing the issue. Setting uiConfig in routeOptions will fix this.

In @gtp/x-index, dynamic data token handler will read the uiConfig from routeOptions and set it to window._wml.config. @walmart/electrode-ui-config reads the ui config and basepath from there and update the fullApiPath accordingly.

@jchip jchip merged commit 196f6d5 into electrode-io:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants