Refactoring to improve performance #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyakarippath
commented
Aug 7, 2020
| @@ -295,16 +295,16 @@ function loadSubAppServerByName(name) { | |||
| ); | |||
| } else if (serverEntry === false) { | |||
| return {}; | |||
| } | |||
|
|
|||
| // generate a server from subapp's main file | |||
There was a problem hiding this comment.
Modified to generate server from subapps main file only if ssr is enabled
divyakarippath
commented
Aug 7, 2020
| @@ -62,8 +62,11 @@ ${inlineRuntimeJS} | |||
| </script>`; | |||
|
|
|||
| // check if any subapp has server side code with initialize method and load them | |||
| const subAppServers = Object.keys(subappUtil.getAllSubAppManifest()) | |||
There was a problem hiding this comment.
Run this only for subapps for that specific route. In subapp-server, we set the subapps for each route to setupContext.routeOptions.__internals
divyakarippath
commented
Aug 7, 2020
| @@ -193,10 +193,9 @@ Response: ${err || body}` | |||
|
|
|||
| const loadSubApp = () => { | |||
| subApp = loadSubAppByName(name); | |||
| subAppServer = loadSubAppServerByName(name); | |||
| subAppServer = loadSubAppServerByName(name, true); | |||
There was a problem hiding this comment.
Now we will call loadSubapp only if ssr is enabled. Setting second argument as true so that loadSubAppServerByName will generate server from subapp's main file if serverEntry is not there.
divyakarippath
commented
Aug 7, 2020
| }; | ||
|
|
||
| loadSubApp(); |
There was a problem hiding this comment.
Need this only if ssr is enabled
divyakarippath
commented
Aug 7, 2020
| @@ -221,10 +220,6 @@ Response: ${err || body}` | |||
|
|
|||
| context.user.numOfSubapps = context.user.numOfSubapps || 0; | |||
|
|
|||
| if (request.app.webpackDev && subAppLoadTime < request.app.webpackDev.compileTime) { | |||
There was a problem hiding this comment.
Needto call loadSubApp only if ssr is enabled. So moved it to line 356
divyakarippath
commented
Aug 7, 2020
| @@ -337,14 +332,6 @@ ${stack}`, | |||
| }; | |||
|
|
|||
| const processSubapp = async () => { | |||
| const ref = { | |||
There was a problem hiding this comment.
Need this only for ssr flow. So moved it to line 358
imgbot bot
pushed a commit
to yishengjiang99/electrode
that referenced
this pull request
Aug 20, 2020
…-io#1717) * Refactoring to improve performance * fixing lint error * fix ssr for prod
imgbot bot
pushed a commit
to yishengjiang99/electrode
that referenced
this pull request
Oct 14, 2020
…-io#1717) * Refactoring to improve performance * fixing lint error * fix ssr for prod
imgbot bot
pushed a commit
to yishengjiang99/electrode
that referenced
this pull request
Oct 14, 2020
…-io#1717) * Refactoring to improve performance * fixing lint error * fix ssr for prod
imgbot bot
pushed a commit
to yishengjiang99/electrode
that referenced
this pull request
Oct 15, 2020
…-io#1717) * Refactoring to improve performance * fixing lint error * fix ssr for prod
imgbot bot
pushed a commit
to yishengjiang99/electrode
that referenced
this pull request
Oct 15, 2020
…-io#1717) * Refactoring to improve performance * fixing lint error * fix ssr for prod
imgbot bot
pushed a commit
to yishengjiang99/electrode
that referenced
this pull request
Oct 15, 2020
…-io#1717) * Refactoring to improve performance * fixing lint error * fix ssr for prod
imgbot bot
pushed a commit
to yishengjiang99/electrode
that referenced
this pull request
Oct 15, 2020
…-io#1717) * Refactoring to improve performance * fixing lint error * fix ssr for prod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.walmart.com/browse/CEECORE-1748