Load cdn mapping script for non js/css assets only if cdn option isenabled #1716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyakarippath
changed the title
divyakarippath
commented
Aug 5, 2020
| @@ -1,6 +1,10 @@ | |||
| // xarc subapp client side lib version 1 | |||
| // load into window.xarcV1 as a global | |||
| (function (w) { | |||
| if (!w._wml) { | |||
There was a problem hiding this comment.
@jchip we were already initializing w._wml in cdn-map.js (https://github.com/electrode-io/electrode/blob/master/packages/subapp-web/src/cdn-map.js#L31).
But now, since we don't load cdn-map.js for dev, added this here also.
If we dont initialize this, electrode-ui-config will throw error where we try to set config values in window._wml
jchip
reviewed
Aug 5, 2020
packages/subapp-web/lib/init.js
Outdated
| @@ -10,9 +10,12 @@ const _ = require("lodash"); | |||
| const assert = require("assert"); | |||
|
|
|||
| module.exports = function setup(setupContext) { | |||
| const cdnEnabled = setupContext.routeOptions.cdn && setupContext.routeOptions.cdn.enable === true; | |||
imgbot bot
pushed a commit
to yishengjiang99/electrode
that referenced
this pull request
Aug 20, 2020
…abled (electrode-io#1716) * load cdn mapping script only if cdn is enabled * refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.walmart.com/browse/CEECORE-1751