Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

followup pull request #1686

Merged
merged 8 commits into from
Jul 1, 2020
Merged

Conversation

yishengjiang99
Copy link
Contributor

  1. jsx-rendererer/tsconfig.json to not include render/context
  2. xarc/webapp to actually import template file
  3. baseline unit tests (wip)

@CLAassistant
Copy link

CLAassistant commented Jul 1, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ yishengjiang99
❌ vn08447


vn08447 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jchip jchip merged commit 2e2201c into electrode-io:jsx-renderer Jul 1, 2020
yishengjiang99 added a commit to yishengjiang99/electrode that referenced this pull request Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants