Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added: mechanism to defer initial state read for sub apps #1630

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

HenrikJoreteg
Copy link
Contributor

hey @jchip and @christianlent! I can't actually seem to get fyn bootstrap to run successfully, so i'm struggling to run tests, etc.

So i figured I'd at least send this PR to clarify what I'm suggesting we do.

Basically, this would allow us to run instance.getInitialState() and thereby defer the reading of that data instead of blocking on that with the inline script (as we discussed).

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@HenrikJoreteg
Copy link
Contributor Author

there's a really good chance this breaks other things 😅 . I'm mainly proposing an idea here, not necessarily saying this is merge-worthy.

@jchip jchip merged commit bb36efb into electrode-io:master Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants