Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add helpful output to admin console and dev proxy #1564

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

dpchamps
Copy link
Contributor

@dpchamps dpchamps commented Mar 16, 2020

problem

It's not immediately obvious from the dev-admin panel what processes are associated with what port. This can lead to some confusion, as outlined here

solution

Make the dev admin panel more transparent without being verbose, with things a dev will want/need to see at some point:

  • Output pid alongside the process that's started / stopped, e.g.:
    • "your app server (PID: 59264) started"
    • "your app server (PID: 59264) exited code 0"
  • Output tree to communicate proxy associations:
    • Screen Shot 2020-03-16 at 4 49 25 PM

Additional Small change:

  • Removed signal reporting when falsy:
    • ""your app server exited code 0 signal: null"

closes #1559

@jchip jchip requested a review from christianlent March 17, 2020 16:58
@jchip jchip merged commit 35500b4 into electrode-io:master Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dev-admin: killing app server does not free port 3000
2 participants