Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#problem
the
loadAssetsFromStats
function will return an empty object whenstats.json
cannot be found. This results in undefined behavior downstream: see the code path in #1558 as an example.Should this fail -- whether from unexpected behavior or invalid inputs, the error delivered to the end-user is unrelated to the original failure.
#solution
Instead of preempting a file io error by returning an empty object, the function should throw with a helpful message. If consumers expect the file to be missing, the callsite should handle as necessary. Otherwise, the end-user get's an idea of what failed.
closes #1558