Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

react-app-dev: Add dev-admin for fastify #1478

Merged
merged 2 commits into from
Dec 26, 2019
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
"use strict";

/* eslint-disable no-console, no-magic-numbers */

const fastifyPlugin = require("fastify-plugin");
const archetype = require("electrode-archetype-react-app/config/archetype");
const Middleware = require("./middleware");
const Url = require("url");
const mime = require("mime");
const fs = require("fs");

async function register(fastify) {
if (!archetype.webpack.devMiddleware) {
console.error("dev-hapi plugin was loaded but WEBPACK_DEV_MIDDLEWARE is not true. Skipping.");
return;
}

const middleware = new Middleware({
baseUrl: () => {
return Url.format({
hostname: process.env.HOST || "localhost",
protocol: fastify.initialConfig.https ? "https" : "http",
port: fastify.server.address().port
});
}
});

middleware.setup();

fastify.addHook("onRequest", async (request, reply) => {
// simulate a res to capture what the devMiddleware might send back
await middleware.process(request.raw, reply, {
skip: () => {},
replyHtml: html => {
reply
.code(200)
.header("Content-Type", "text/html")
.send(html);
},
replyNotFound: () => {
reply.callNotFound();
},
replyError: err => {
reply.send(err);
},
replyStaticData: data => {
const type = mime.lookup(request.url);
if (type) {
const charset = mime.charsets.lookup(type);
reply.header("Content-Type", type + (charset ? `; charset=${charset}` : ""));
}
reply.code(200).send(data);
},
replyFile: async name => {
let data;
try {
data = fs.readFileSync(name);
} catch (e) {
reply.code(404);
return;
}
const type = mime.lookup(name);
if (type) {
const charset = mime.charsets.lookup(type);
reply.header("Content-Type", type + (charset ? `; charset=${charset}` : ""));
}
reply.code(200).send(data);
}
});
});
fastify.use(middleware.devMiddleware);
fastify.use(middleware.hotMiddleware);
}

module.exports = fastifyPlugin(register, {
name: "electrode-dev-hapi"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hapi?

});
Original file line number Diff line number Diff line change
@@ -0,0 +1,220 @@
"use strict";

const events = require("events");
const fs = require("fs");
const mockRequire = require("mock-require");
const os = require("os");
const path = require("path");
const sinon = require("sinon");

function fakeReply(sandbox) {
const reply = sandbox.stub();
reply.savedHeaders = [];
reply.savedPayloads = [];
reply.callNotFoundCount = 0;
reply.code = function(status) {
reply.statusCode = status;
return reply;
};
reply.header = function(name, value) {
reply.savedHeaders.push({ name, value });
return reply;
};
reply.send = function(payload) {
reply.savedPayloads.push(payload);
return reply;
};
reply.callNotFound = function() {
reply.callNotFoundCount++;
return reply;
};
return reply;
}

describe("dev-admin-fastify", function() {
this.timeout(10000);
let sandbox;
let mockFastify;
let MiddlewareClass;
let request;
let reply;

function registerFastify() {
const register = require("../../../lib/dev-admin/dev-fastify");
register(mockFastify);
}

beforeEach(() => {
sandbox = sinon.createSandbox();
const fastifyEvent = new events.EventEmitter();
request = sandbox.stub();
reply = fakeReply(sandbox);
mockFastify = {
initialConfig: {
https: false
},
hooks: fastifyEvent,
addHook: (evt, func) => {
fastifyEvent.on(evt, func);
},
use: sandbox.spy(),
server: {
address: () => ({ port: 9000 })
}
};
MiddlewareClass = function(args) {
MiddlewareClass.initArgs = args;
this.hotMiddleware = "hot";
this.devMiddleware = "dev";
this.process = MiddlewareClass.processStub;
this.setup = () => {
MiddlewareClass.setupCount++;
};
};
MiddlewareClass.initArgs = [];
MiddlewareClass.setupCount = 0;
MiddlewareClass.processStub = sandbox.stub();

mockRequire("../../../lib/dev-admin/middleware", MiddlewareClass);
mockRequire("electrode-archetype-react-app/config/archetype", {
webpack: { devMiddleware: true }
});
});

afterEach(() => {
mockRequire.stopAll();
sandbox.restore();
delete require.cache[require.resolve("../../../lib/dev-admin/dev-fastify")];
});

it("register loads dev and hot middleware", () => {
registerFastify();
expect(MiddlewareClass.setupCount).eq(1);
expect(mockFastify.use.callCount).eq(2);
expect(mockFastify.use.calledWith(MiddlewareClass.hotMiddleware));
expect(mockFastify.use.calledWith(MiddlewareClass.devMiddleware));
expect(mockFastify.hooks.listenerCount("onRequest")).eq(1);
});

it("register baseUrl defaults to localhost", () => {
registerFastify();
expect(MiddlewareClass.initArgs.baseUrl()).eq("http://localhost:9000");
});

it("register baseUrl uses HOST env", () => {
process.env.HOST = "walmart.com";
registerFastify();
expect(MiddlewareClass.initArgs.baseUrl()).eq("http://walmart.com:9000");
delete process.env.HOST;
});

it("register baseUrl uses https", () => {
mockFastify.initialConfig.https = true;
registerFastify();
expect(MiddlewareClass.initArgs.baseUrl()).eq("https://localhost:9000");
});

it("onRequest handler calls process", async () => {
registerFastify();
expect(mockFastify.hooks.listenerCount("onRequest")).eq(1);

await mockFastify.hooks.emit("onRequest", request, reply);
expect(MiddlewareClass.processStub.callCount).eq(1);
});

it("process calls replyHTML to print HTML content", async () => {
registerFastify();
MiddlewareClass.processStub.callsFake((req, rpy, handlers) => {
handlers.replyHtml("Some html content");
});
await mockFastify.hooks.emit("onRequest", request, reply);
expect(reply.called);
expect(reply.statusCode).eq(200);
expect(reply.savedHeaders).deep.eq([{ name: "Content-Type", value: "text/html" }]);
expect(reply.savedPayloads).deep.eq(["Some html content"]);
});

it("process calls replyNotFound", async () => {
registerFastify();
MiddlewareClass.processStub.callsFake((req, rly, handlers) => {
handlers.replyNotFound();
});

expect(reply.callNotFoundCount).eq(0);
await mockFastify.hooks.emit("onRequest", request, reply);
expect(reply.callNotFoundCount).eq(1);
});

it("process calls replyError", async () => {
registerFastify();
MiddlewareClass.processStub.callsFake((req, rly, handlers) => {
handlers.replyError("Yo Error!");
});

expect(reply.savedPayloads.length).eq(0);
await mockFastify.hooks.emit("onRequest", request, reply);
expect(reply.savedPayloads.length).eq(1);
expect(reply.savedPayloads[0]).eq("Yo Error!");
});

it("process calls replyStaticData", async () => {
registerFastify();
MiddlewareClass.processStub.callsFake((req, rly, handlers) => {
handlers.replyStaticData("Yo Data!");
});

expect(reply.savedPayloads.length).eq(0);
request.url = "http://example.com/animal.gif";
await mockFastify.hooks.emit("onRequest", request, reply);
expect(reply.statusCode).eq(200);
expect(reply.savedHeaders[0]).deep.eq({ name: "Content-Type", value: "image/gif" });
expect(reply.savedPayloads.length).eq(1);
expect(reply.savedPayloads[0]).eq("Yo Data!");
});

it("process calls replyFile", async () => {
registerFastify();
const tmpFile = path.join(os.tmpdir(), "valid.txt");
fs.writeFileSync(tmpFile, "blah");

MiddlewareClass.processStub.callsFake((req, rly, handlers) => {
handlers.replyFile(tmpFile);
});

expect(reply.savedPayloads.length).eq(0);
await mockFastify.hooks.emit("onRequest", request, reply);
expect(reply.statusCode).eq(200);
expect(reply.savedHeaders[0]).deep.eq({
name: "Content-Type",
value: "text/plain; charset=UTF-8"
});
expect(reply.savedPayloads.length).eq(1);
expect(reply.savedPayloads[0].toString()).eq("blah");
});

it("process calls replyFile with invalid file", async () => {
registerFastify();
const tmpFile = "yolo.txt";
MiddlewareClass.processStub.callsFake((req, rly, handlers) => {
handlers.replyFile(tmpFile);
});

expect(reply.savedPayloads.length).eq(0);
await mockFastify.hooks.emit("onRequest", request, reply);
expect(reply.statusCode).eq(404);
expect(reply.savedPayloads.length).eq(0);
});

it("middleware skip does not load middleware", () => {
mockRequire("electrode-archetype-react-app/config/archetype", {
webpack: { devMiddleware: false }
});

const register = require("../../../lib/dev-admin/dev-fastify");
register(mockFastify);

expect(MiddlewareClass.setupCount).eq(0);
expect(mockFastify.use.callCount).eq(0);
expect(mockFastify.hooks.listenerCount("onRequest")).eq(0);
});
});