Update github action and fix tests (#1910)

* Update github action and adding in several test fixes with rush

Co-authored-by: Arun Vishnu <[email protected]>

.github/workflows/nodejs.yml

@@ -1,13 +1,18 @@
-# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node
-# For more information see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
+# This workflow will do a clean install of node dependencies, build the source code and run tests across different versions of node.
+# It then publish a packages to npm registry when PR against a given target branch is merged.
+# For more information on github actions see: https://help.github.com/actions/language-and-framework-guides/using-nodejs-with-github-actions
+# For more information on publishing packages see: https://docs.github.com/en/actions/publishing-packages/publishing-nodejs-packages
 
 name: Node.js CI
 
 on:
   push:
-    branches: [master, next-webpack-5]
+    branches: [ "master", "next-webpack-5", "rush-pnpm-migration" ]
   pull_request:
-    branches: [master, next-webpack-5]
+    branches: [ "master", "next-webpack-5", "rush-pnpm-migration"  ]
+
+  # Allows you to run this workflow manually from the Actions tab
+  workflow_dispatch:
 
 jobs:
   build:
@@ -18,10 +23,13 @@ jobs:
         node-version: [12.x, 14.x, 16.x]
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
+
       - name: Use Node.js ${{ matrix.node-version }}
-        uses: actions/setup-node@v1
+        uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node-version }}
+
       - run: node common/scripts/install-run-rush.js install
       - run: node common/scripts/install-run-rush.js rebuild --verbose
+

common/config/rush/.npmrc

@@ -19,4 +19,4 @@
 #   //registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN}
 #
 registry=https://registry.npmjs.org/
-always-auth=false
+always-auth=false

common/config/rush/.npmrc-publish

@@ -18,3 +18,6 @@
 #
 #   //registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN}
 #
+registry=https://registry.npmjs.org/
+always-auth=true
+//registry.npmjs.org/:_authToken=${NPM_AUTH_TOKEN}

common/config/rush/command-line.json

@@ -17,6 +17,7 @@
       "summary": "Run tests in each packages",
       "description": "Run tests in each packages. Runs `npm run test` for each package. Each package can have its own definition of `npm run test`",
       "allowWarningsInSuccessfulBuild": true,
+      "ignoreDependencyOrder": false,
       "ignoreMissingScript": true,
       "enableParallelism": false
     },
@@ -27,7 +28,7 @@
       "description": "Run lint in each packages. Runs `npm run lint` for each package if present.",
       "allowWarningsInSuccessfulBuild": true,
       "ignoreMissingScript": true,
-      "enableParallelism": true
+      "enableParallelism": false
     }
     // {
     //   /**