[fix] drop webpack deprecated stuff

electrode-io · Oct 15, 2020 · f099cf4 · f099cf4
1 parent ffe4560
commit f099cf4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/packages/xarc-app-dev/src/lib/dev-admin/middleware.ts b/packages/xarc-app-dev/src/lib/dev-admin/middleware.ts
@@ -124,15 +124,14 @@ class Middleware {
 
     config.plugins = [
       new webpack.HotModuleReplacementPlugin(),
-      new webpack.NoEmitOnErrorsPlugin()
-    ].concat(config.plugins);
+      new webpack.NoEmitOnErrorsPlugin(),
+      options.progress !== false && new webpack.ProgressPlugin({ profile: options.progressProfile })
+    ]
+      .concat(config.plugins)
+      .filter(x => x);
 
     const compiler = webpack(config);
 
-    if (options.progress !== false) {
-      compiler.apply(new webpack.ProgressPlugin({ profile: options.progressProfile }));
-    }
-
     const webpackDevOptions = _.merge(
       {
         // https: false,

diff --git a/packages/xarc-webpack/src/plugins/done-plugin.ts b/packages/xarc-webpack/src/plugins/done-plugin.ts
@@ -6,7 +6,7 @@ class DonePlugin {
   }
 
   apply(compiler) {
-    compiler.plugin("done", () => {
+    compiler.hooks.done.tap("DonePlugin", () => {
       this._func();
     });
   }