fix: return 404 for /favicon.ico in webpack dev server (Hapi) (#1580)

electrode-io · Apr 2, 2020 · eae84f2 · eae84f2
1 parent 0c00a46
commit eae84f2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/packages/xarc-app-dev/lib/dev-admin/dev-hapi.js b/packages/xarc-app-dev/lib/dev-admin/dev-hapi.js
@@ -27,6 +27,9 @@ function register(server, options, next) {
   server.ext({
     type: "onRequest",
     method: (request, reply) => {
+      if (request.path === "/favicon.ico") {
+        return reply("").code(404);
+      }
       const { req } = request.raw;
 
       // simulate a res to capture what the devMiddleware might send back

diff --git a/packages/xarc-app-dev/lib/dev-admin/dev-hapi17.js b/packages/xarc-app-dev/lib/dev-admin/dev-hapi17.js
@@ -25,6 +25,9 @@ function register(server) {
   server.ext({
     type: "onRequest",
     method: (request, h) => {
+      if (request.path === "/favicon.ico") {
+        return h.response("").code(404).takeover();
+      }
       const { req } = request.raw;
 
       // simulate a res to capture what the devMiddleware might send back