Skip to content

Commit

Permalink
drop i18n and flow from default (#1501)
Browse files Browse the repository at this point in the history
* handle css bundles for subapps

* scope client side lib for subapps

* default to babel runtime and polyfill for subapps

* drop i18n and flow from default
  • Loading branch information
jchip authored Jan 20, 2020
1 parent 012c344 commit ad62ae6
Show file tree
Hide file tree
Showing 7 changed files with 853 additions and 1,095 deletions.
2 changes: 1 addition & 1 deletion packages/electrode-archetype-opt-flow/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,6 @@
"optionalTagName": "flow",
"expectTag": true,
"devOnly": true,
"defaultInstall": true
"defaultInstall": false
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -44,19 +44,23 @@ const basePlugins = [
"@babel/plugin-proposal-class-properties",
{ loose: looseClassProps }
],
[
"babel-plugin-i18n-id-hashing",
{
varsContainingMessages: ["defaultMessages", "translations"]
}
],
[
"babel-plugin-react-intl",
{
messagesDir: "./tmp/messages/",
enforceDescriptions: true
}
],
//
// i18n has not been used at all and these are very outdated
// remove them for now until they can be updated
//
// [
// "babel-plugin-i18n-id-hashing",
// {
// varsContainingMessages: ["defaultMessages", "translations"]
// }
// ],
// [
// "babel-plugin-react-intl",
// {
// messagesDir: "./tmp/messages/",
// enforceDescriptions: true
// }
// ],
"transform-node-env-inline",
"babel-plugin-lodash",
"@babel/plugin-transform-runtime",
Expand Down
7 changes: 0 additions & 7 deletions packages/electrode-archetype-react-app-dev/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,10 @@
"acorn": "^6.0.5",
"ansi-to-html": "^0.6.8",
"autoprefixer": "^9.6.0",
"babel-core": "7.0.0-bridge.0",
"babel-loader": "^8.0.4",
"babel-plugin-dynamic-import-node": "^2.2.0",
"babel-plugin-i18n-id-hashing": "^2.1.0",
"babel-plugin-lodash": "^3.3.4",
"babel-plugin-minify-dead-code-elimination": "^0.5.0",
"babel-plugin-react-intl": "^3.0.1",
"babel-plugin-transform-node-env-inline": "^0.4.3",
"babel-plugin-transform-react-remove-prop-types": "^0.4.20",
"batch": "^0.6.1",
Expand Down Expand Up @@ -114,7 +111,6 @@
"optionalDependencies": {
"electrode-archetype-opt-critical-css": "^1.0.4",
"electrode-archetype-opt-eslint": "^1.0.4",
"electrode-archetype-opt-flow": "^1.0.3",
"electrode-archetype-opt-inferno": "^0.2.12",
"electrode-archetype-opt-jest": "^24.0.1",
"electrode-archetype-opt-karma": "^2.0.8",
Expand All @@ -125,7 +121,6 @@
"electrode-archetype-opt-preact": "^1.0.1",
"electrode-archetype-opt-pwa": "^1.0.7",
"electrode-archetype-opt-react": "^2.0.5",
"electrode-archetype-opt-react-intl": "^1.0.1",
"electrode-archetype-opt-sass": "^1.0.10",
"electrode-archetype-opt-stylus": "^1.0.3",
"electrode-archetype-opt-sinon": "^1.0.4",
Expand Down Expand Up @@ -155,7 +150,6 @@
"optionalDependencies": {
"electrode-archetype-opt-critical-css": "../electrode-archetype-opt-critical-css",
"electrode-archetype-opt-eslint": "../electrode-archetype-opt-eslint",
"electrode-archetype-opt-flow": "../electrode-archetype-opt-flow",
"electrode-archetype-opt-inferno": "../electrode-archetype-opt-inferno",
"electrode-archetype-opt-jest": "../electrode-archetype-opt-jest",
"electrode-archetype-opt-karma": "../electrode-archetype-opt-karma",
Expand All @@ -166,7 +160,6 @@
"electrode-archetype-opt-preact": "../electrode-archetype-opt-preact",
"electrode-archetype-opt-pwa": "../electrode-archetype-opt-pwa",
"electrode-archetype-opt-react": "../electrode-archetype-opt-react",
"electrode-archetype-opt-react-intl": "../electrode-archetype-opt-react-intl",
"electrode-archetype-opt-sass": "../electrode-archetype-opt-sass",
"electrode-archetype-opt-stylus": "../electrode-archetype-opt-stylus",
"electrode-archetype-opt-sinon": "../electrode-archetype-opt-sinon",
Expand Down
1 change: 1 addition & 0 deletions samples/demo-tree-shaking/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
"good-console": "^7.1.0",
"lodash": "^4.17.10",
"milligram": "^1.3.0",
"react-intl": "^3.11.0",
"react-notify-toast": "^0.4.1",
"react-router-config": "^1.0.0-beta.4",
"react-router-dom": "^4.3.1"
Expand Down
3 changes: 0 additions & 3 deletions samples/universal-react-node/babel.config.js

This file was deleted.

Loading

0 comments on commit ad62ae6

Please sign in to comment.