Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check custom action usage inside other custom actions by using a queue #59

Closed
wants to merge 0 commits into from

Conversation

NoelTautges
Copy link
Contributor

This PR fixes bug #58 by using a queue to check custom action usage.

Beginning with the main body of the Shortcut, custom action uses are detected and added to the queue. The function continuously cycles through the queue, adding newly used custom actions, until all possible matches are exhausted.

Notes:

  • It makes sure the action isn't already marked as used because otherwise recursive functions go haywire.
  • It adds a dummy custom action to make the loop that goes through the queue more clean. This is... questionable, but it does work.
  • This PR technically contains 6 commits because of GitHub nonsense, but there's only 2 that actually make changes that haven't already been merged into main.

@NoelTautges
Copy link
Contributor Author

Hey, guess who accidentally screwed up his pull request by syncing his fork with the upstream repository? It's me, baby! Making a new one in a sec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant