-
Notifications
You must be signed in to change notification settings - Fork 959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ENTSO-E parser to use new proxy #6312
Conversation
PR Analysis
PR Feedback💡 General suggestions: The changes in this PR are clear and straightforward. However, it would be beneficial to add tests to ensure that the new proxy service works as expected. This could include tests to check the response from the new proxy service and handle any potential errors. 🤖 Code feedback:
✨ Usage tips:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's working perfectly!
There was a reason the checklist had two boxes though 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's working perfectly!
There was a reason the checklist had two boxes though 😉
Looks like we are mocking the tokens in a test too, we need to update that. |
Haha, I've always just read the "pnpm ..." and assumed it was only about frontend 😅 |
Pretty sure I uninstalled isort and black, I don't think we ever had all of them in there since they where so slow... |
On the monorepo we still run isort and black on pre-commit, so maybe it's time to replace that :) |
Yeah, I noticed we where still using black, led to some frustration when there was minor differences between ruff and black and I had autosave and format on save on and ruff as the default 😅. But I can take care of the pre-commit hook in here, then we can start replacing things on the backend too. |
Will merge and release this to production tomorrow so I can watch in case issues occur! :) |
Description
Changes ENTSO-E parser to query via a new proxy service.
Double check
poetry run test_parser "zone_key"