Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create helper script to sum subZone capacities #4724

Closed

Conversation

VIKTORVAV99
Copy link
Member

@VIKTORVAV99 VIKTORVAV99 commented Oct 28, 2022

This helper script sum a countries sub zone capacities and writes them to the country level capacity object.

Note
Right now this only sum one zone at a time but it can easily be modified to update all zones and could be made in such a way it easily plugs into other scripts.

@madsnedergaard
Copy link
Member

cc @unitrium :)

@unitrium
Copy link
Contributor

I already created a python script to handle this (not merged yet). It uses the python classes we have for capacity which I think might be better, so that if we do a change there it will be reflected. It will be merged with the US aggregation ;)

@VIKTORVAV99
Copy link
Member Author

I already created a python script to handle this (not merged yet). It uses the python classes we have for capacity which I think might be better, so that if we do a change there it will be reflected. It will be merged with the US aggregation ;)

Would it be possible to add this to the backend instead as a computational step, so we don't even need to sum the capacities for the countries with subzones?

@unitrium
Copy link
Contributor

Should be doable, I'm also thinking it could be nice to keep a trace of the evolution of production capabilities somewhere. I will check that with the team, if we can add it in our backlog. For the short term, we will stick with the YAML files so that we can ship quickly the US aggregation.

@VIKTORVAV99
Copy link
Member Author

I already summed the US capacities with my own script, so you don't have to keep that in mind 😅.
So have a chat with the team and see what they say, if we want to discuss it more in depth just hit me up on slack.

I also think it would be nice with historical capacities, I actually created an RFC for it a while back at #4396 but the historical part of it got lost when we split the files.

@VIKTORVAV99
Copy link
Member Author

Closed in favor of #4741.

@VIKTORVAV99 VIKTORVAV99 closed this Nov 7, 2022
@VIKTORVAV99 VIKTORVAV99 deleted the unfair_violet_shrew branch February 7, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants