WIP - Add French translation #350
Conversation
|
@ThierryOllivero @brunolajoie can you review / improve the translations? |
|
What are the 3 files? lang.json , en.js and fr.js ? |
|
yes! |
|
Simpler for the language review:
@brunolajoie @ThierryOllivero can you review? |
|
Actually there was a couple of bugs that I just fixed. Here are the new tooltips:
|
|
Si t'as plus ce petit bug, ca me vas |
|
Good catch @brunolajoie ! Please validate the new version: Also: note that the facebook/twitter buttons have changed language :) |
|
I would change "combien de CO2 a été émis" by "quelle quantité de CO2 a été émise". I would change "voir (data sources)" by "(voir data sources)", as it is the case in English. |
|
Much better! Should be ok now. |
|
Européenne prends deux "n"! J'ai traduit les pays aussi:
|
|
@nikkozzblu can you do the final review? |
There was a problem hiding this comment.
Looks good to me, really like the effort to structure the locale files, as you say we can have the lang.json extracted by server from the en.json, fr.json ,... in a future refactoring.
Now time to activate all the good wills that proposed to translate here in their languages;
Maybe a quick part in readme specific to translation can be efficieny....
I will look if i can find somebody for spanish :p
| @@ -5,10 +5,14 @@ | |||
| <meta name="description" content="Electricity Map is a live visualization of where your electricity comes from and how much CO2 was emitted to produce it." /> | |||
| <meta property="og:description" content="Electricity Map is a live visualization of where your electricity comes from and how much CO2 was emitted to produce it." /> | |||
| <meta property="og:image" content="https://cloud.githubusercontent.com/assets/1655848/20340757/5ada5cf6-abe3-11e6-97c4-e68929b8a135.png" /> | |||
| <meta property="og:title" content="Electricity Map | Live CO2 emissions of the European electricity consumption" /> | |||
| <meta property="og:title" content="<%= __('misc.maintitle') %>" /> | |||
| <meta property="og:type" content="website" /> | |||
There was a problem hiding this comment.
I don t know if that on purpose but you don t have anymore Electricity map | before the title
Refers to #311
TODO:
Share translations between frontend and backend(later)