Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganizes and cleans up all geo scripts #3331

Merged
merged 17 commits into from
Sep 6, 2021
Merged

Reorganizes and cleans up all geo scripts #3331

merged 17 commits into from
Sep 6, 2021

Conversation

madsnedergaard
Copy link
Member

@madsnedergaard madsnedergaard commented Aug 25, 2021 •
edited
Loading

Description

The geo scripts were quite messy and all over the place, so I have:

  • rearranged everything into a geo/ folder to keep it together
  • Cleaned up scripts and rewritten some code to make it cleaner
  • Moved all constants and json imports from generate-geometries.js to a new geometries-config.js

TODO

  • Figure out why world.json is regenerated and what has changed -> turns out there was a mistake in the geojson imports which meant we missed some maps :)

@madsnedergaard madsnedergaard marked this pull request as ready for review August 25, 2021 12:13
@madsnedergaard madsnedergaard requested a review from skovhus August 25, 2021 12:13
skovhus
skovhus approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@skovhus skovhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A much needed refactor! Looks solid. 👏

@madsnedergaard madsnedergaard enabled auto-merge (squash) September 6, 2021 08:38
@madsnedergaard madsnedergaard merged commit ad0c266 into master Sep 6, 2021
@madsnedergaard madsnedergaard deleted the mn/geo/cleanup-geo-scripts branch September 6, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skovhus skovhus skovhus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madsnedergaard @skovhus