Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge HTML for PDF outputs #640

Merged
merged 41 commits into from
Nov 11, 2022
Merged

Merge HTML for PDF outputs #640

merged 41 commits into from
Nov 11, 2022

Conversation

arthurattwell
Copy link
Member

@arthurattwell arthurattwell commented Oct 16, 2022 •
edited
Loading

This enables (by default) merging all of a book's HTML files into one for PDF output. This is an important step for various reasons:

  • We can now break chapters up into smaller markdown/HTML files, without that adding page-breaks in PDF output. Shorter pages are better for the web (more readable and probably more SEO-friendly).
  • It's a step towards being able to use PDF renderers like Antenna House and PagedJS, both of which require a single input HTML file.

This is a significant restructuring of our HTML, though, because we can no longer use the <body> element to store chapter-specific attributes. These are now moved to the .wrapper.

Also, it's important to never use IDs in CSS or Javascript that acts on the PDF after merging, because the merging process renames all IDs (to avoid duplicates in different chapters). It also renames all internal links accordingly.

Merging can be avoiding on output by adding --merged false to the output command, e.g. npm run eb -- output -f screen-pdf --merged false.

@arthurattwell
Create merge function for merging HTML files
ef82be2
@arthurattwell
Restructure run scripts to avoid cyclical dependencies
15fcee5 
And add refinements to naming, etc.
@arthurattwell
Rename wrapper and content id to classes, etc.
36399ba
@arthurattwell
Avoid copying API files on non-web outputs
140e326
@arthurattwell
Update indexes and API content
ab6d789
@arthurattwell
Add ending newlines
ef8fb01
@arthurattwell
Update updates list
4e26b18
@arthurattwell
Fix accordion with new structure
5875a3a
@arthurattwell
Exclude common EBT CICD files
56b6511
@arthurattwell
Further accordion fixes for new structure
7276664
@arthurattwell
Add GH action to check that site builds on PRs
9668ecf
@arthurattwell
Typo in code comment
e011dba
@arthurattwell
Fixes and docs, mainly for merged HTML changes
73ba4fe
@arthurattwell
Fix and improve styles
8ecc468
@arthurattwell
Adjust and update samples content and indexes
11fd824
@arthurattwell
Update files.txt
716b200
@arthurattwell
Improve gitpod setup
7230e99 
Based on Gitpod support recommendations and docs
@arthurattwell
Try not using gitpod user
d927455
@arthurattwell
Use rvm for Ruby gems mgmt
c5c4a22
@arthurattwell
Add user
97d8a44
@arthurattwell
Simplify Dockerfule, using ruby-2 base
7f83d66
@arthurattwell
Try to fix permissions, gem and npm install issues
f631794
@arthurattwell
Remove redundant, problematic steps
96d2ea3
@arthurattwell
Move Jekyll install to init to try avoid errors
83ea2dc
@arthurattwell
Try running all installs in one init
66a0e13
@arthurattwell
Try more sensible syntax for init
155a0fd
@arthurattwell
Try specifying gems path
9fb1fde
@arthurattwell
Merge pull request #643 from electricbookworks/fix-gitpod
568dd74 
Improve gitpod setup
@arthurattwell
Use gitpod user for gem paths
520ca74
@arthurattwell
Try more accurate gems path
3d5d962
@arthurattwell arthurattwell merged commit da82526 into restructure-meta-text Nov 11, 2022
@arthurattwell arthurattwell deleted the merged-html branch November 11, 2022 09:53
@arthurattwell arthurattwell mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arthurattwell