Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title abstraction #597

Merged
merged 4 commits into from
Sep 20, 2021
Merged

Conversation

bertuss
Copy link
Contributor

@bertuss bertuss commented Sep 15, 2021

No description provided.

@netlify
Copy link

netlify bot commented Sep 15, 2021

✔️ Deploy Preview for electric-book ready!

🔨 Explore the source changes: e38259e

🔍 Inspect the deploy log: https://app.netlify.com/sites/electric-book/deploys/61485fdd729508000765c0d8

😎 Browse the preview: https://deploy-preview-597--electric-book.netlify.app/samples/text/01-10-questions

@arthurattwell
Copy link
Member

Thanks, @bertuss.

As I read this (may be missing something) there is no html-title set for PDF outputs with multiple files (print-pdf-file-list.size > 1).

So I don't think we can do without setting these defaults first:

{% capture html-title %}{{ project-name }}{% endcapture %}
{% if title and title != "" %}
    {% capture html-title %}{{ title }}{% endcapture %}
{% endif %}

In the original, we only override html-title for PDF outputs if *-pdf-file-list.size > 1. So I think we should still do that last.

@bertuss bertuss merged commit 659bcb3 into electricbookworks:master Sep 20, 2021
@bertuss bertuss deleted the title-abstraction branch September 20, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants