wip: change interactive_one to read/write from/to FS device. #330
+353
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Built bundles: |
samwillis
force-pushed
the
samwillis/interactive-one-from-file
branch
3 times, most recently
from
ebdd8af
to
9fbeae8
Compare
pmp-p
reviewed
Oct 8, 2024
| +#define PGS_IN "/tmp/pglite/base/.s.PGSQL.5432.in" | ||
| +#define PGS_OLOCK "/tmp/pglite/base/.s.PGSQL.5432.lock.out" | ||
| +#define PGS_OUT "/tmp/pglite/base/.s.PGSQL.5432.out" | ||
| +#define PGS_ILOCK "/tmp/pglite/.s.PGSQL.5432.lock.in" |
There was a problem hiding this comment.
potential problem is when mounting a db path under node running native, it is the only directory shared with host : /tmp/pglite is only MEMFS so other processes cannot use the socket file (eg to make a unix socket gateway ). /tmp/pglite/base is expected to be in raw mounted fs
There was a problem hiding this comment.
I move them as it doesn't seem to be possible to mount a device inside /tmp/pglite/base with the NodeFS, it throws a FS error.
samwillis
force-pushed
the
samwillis/interactive-one-from-file
branch
3 times, most recently
from
b9e3b91
to
409c7fa
Compare
samwillis
force-pushed
the
samwillis/interactive-one-from-file
branch
from
7ab2382
to
2553edc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.