Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Elixir client #1833

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Add Elixir client #1833

wants to merge 25 commits into from

Conversation

magnetised
Copy link
Contributor

No description provided.

@netlify Netlify
Copy link

netlify bot commented Oct 10, 2024 •
edited
Loading

✅ Deploy Preview for electric-next ready!

Name Link
🔨 Latest commit 03226a2
🔍 Latest deploy log https://app.netlify.com/sites/electric-next/deploys/670e37dd10fd540008828bdd
😎 Deploy Preview https://deploy-preview-1833--electric-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

thruflo
thruflo reviewed Oct 10, 2024
View reviewed changes
packages/elixir-client/lib/electric/client.ex Outdated
}
@type schema :: %{String.t() => column()}
@type message :: ControlMessage.t() | ChangeMessage.t()
@type param :: :offset | :update_mode | :shape_id | :live | :where
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting that we recently merged #1826 which adds a cursor param, with value set from the response headers. Which is key to making things work with our cloud.

@thruflo
Copy link
Contributor

thruflo commented Oct 14, 2024

Hey, can I also request that this PR also updates https://github.com/electric-sql/electric/blob/main/website/docs/api/clients/elixir.md -- shout if you want to sync on what we should document there.

@magnetised magnetised force-pushed the magnetised/elixir-client branch 2 times, most recently from a419a86 to ae5bf79 Compare October 15, 2024 08:02
@magnetised
Copy link
Contributor Author

@thruflo have done a quick re-write of the elixir client docs: 03226a2

Happy to evolve

@thruflo
Copy link
Contributor

thruflo commented Oct 15, 2024

@thruflo have done a quick re-write of the elixir client docs: 03226a2

Happy to evolve

Looks good. Is the idea to merge this separately of electric_phoenix and thus not mention that yet? If so, let's make sure to add info about the Phoenix streams integration when that's published too.

@magnetised
Copy link
Contributor Author

Looks good. Is the idea to merge this separately of electric_phoenix and thus not mention that yet? If so, let's make sure to add info about the Phoenix streams integration when that's published too.

yeah. we really need the client in hex to make the separate phoenix integration work.

@magnetised magnetised marked this pull request as ready for review October 16, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thruflo thruflo thruflo left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@magnetised @thruflo