Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: rename action header -> operation to match PG #1481

Merged
merged 11 commits into from
Aug 8, 2024
Merged

Conversation

KyleAMathews
Copy link
Contributor

Fixes #1437

Copy link

netlify bot commented Aug 6, 2024

Deploy Preview for electric-next canceled.

Name Link
🔨 Latest commit 86c6085
🔍 Latest deploy log https://app.netlify.com/sites/electric-next/deploys/66b4252ca6146f000793dfe5

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a generated file. Do we need it in the Git repo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm no, I'll remove that in a separate PR as it came in with the nextjs one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix: #1491

@robacourt
Copy link
Contributor

Sorry Kyle, I've merged #1485 and it conflict with this. You'll need to rebase and there's a few mentions of action in my PR

@KyleAMathews KyleAMathews merged commit 8e584a1 into main Aug 8, 2024
5 checks passed
@KyleAMathews KyleAMathews deleted the operation branch August 8, 2024 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize on "operation" vs. "action"
3 participants