-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server to client error messages #1406
Conversation
Minor comment but i think the error that is displayed on the client should make very clear that this is a server-side error, otherwise it will confuse people and they will think there is a problem with the client. |
40b14a1
to
dfb94aa
Compare
Co-authored-by: Oleksii Sholik <[email protected]>
The error message is now:
Hope that's clean enough @kevin-dp ? |
https://linear.app/electric-sql/issue/VAX-1983/improve-error-reporting-from-server-to-client
This PR add the ability of the client to show friendly error messages when the error has originated on the server.
For example:
At this stage I've not tried to hide any noise such as the stack trace in these scenarios. So the user in fact sees all of this:
I've also added friendly error message generation on the server for data validation errors as an example of how you would implement the friendly error messages. Once the permissions system has been added, rejected writes could also generate a friendly error message in a similar way.
The client will now also see error messages that were already being set in the SatErrorResp such as: