Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition for live-polling cursors #1837

Closed
KyleAMathews opened this issue Oct 11, 2024 · 0 comments · Fixed by #1856
Closed

Fix race condition for live-polling cursors #1837

KyleAMathews opened this issue Oct 11, 2024 · 0 comments · Fixed by #1856

Comments

@KyleAMathews
Copy link
Contributor

Follow-up to #1826 after some more testing

There's still a slight chance that a live request is cached too long as the first long-polling request might get the same cursor as the second given networking inconsistencies, etc.

The fix is that when creating the cursor, the server should check what cursor was used by the current request and if the two cursors are the same, it should append something to ensure the cursor busts the caches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant