fix(sync-server): Fix error that occurs when /shape response stream…

… is closed before it is complete (#1489) This closes #1440
electric-sql · Aug 7, 2024 · d24993b · d24993b
1 parent 3a412bf
commit d24993b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/.changeset/fifty-frogs-warn.md b/.changeset/fifty-frogs-warn.md
@@ -0,0 +1,6 @@
+---
+"@core/sync-service": patch
+---
+
+Fix error that occurs when a `/shape` response stream is closed before it is complete,
+for example when `curl --head` is used to call the endpoint.
diff --git a/packages/sync-service/lib/electric/plug/serve_shape_plug.ex b/packages/sync-service/lib/electric/plug/serve_shape_plug.ex
@@ -330,7 +330,11 @@ defmodule Electric.Plug.ServeShapePlug do
         {:ok, conn} ->
           {:cont, conn}
 
-        {:error, :closed} ->
+        {:error, "closed"} ->
+          {:halt, conn}
+
+        {:error, reason} ->
+          Logger.error("Error while streaming response: #{inspect(reason)}")
           {:halt, conn}
       end
     end)