Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added guide to migrate to Ubuntu 24.04 #409

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Xartos
Copy link
Contributor

@Xartos Xartos commented Jan 15, 2025

Warning

This is a public repository, ensure not to disclose:

  • personal data beyond what is necessary for interacting with this pull request, nor
  • business confidential information, such as customer names.

What kind of PR is this?

Required: Mark one of the following that is applicable:

  • kind/feature
  • kind/improvement
  • kind/deprecation
  • kind/documentation
  • kind/clean-up
  • kind/bug
  • kind/other

Optional: Mark one or more of the following that are applicable:

Important

Breaking changes should be marked kind/admin-change or kind/dev-change depending on type
Critical security fixes should be marked with kind/security

  • kind/admin-change
  • kind/dev-change
  • kind/security
  • kind/adr

What does this PR do / why do we need this PR?

Migration docs for how to migrate to ubuntu 24.04

  • Fixes elastisys/ck8s-issue-tracker#348

Information to reviewers

Checklist

  • Proper commit message prefix on all commits
  • Change checks:
    • The change is transparent
    • The change is disruptive
    • The change requires no migration steps
    • The change requires migration steps
  • Metrics checks:
    • The metrics are still exposed and present in Grafana after the change
    • The metrics names didn't change (Grafana dashboards and Prometheus alerts are not affected)
    • The metrics names did change (Grafana dashboards and Prometheus alerts were fixed)
  • Logs checks:
    • The logs do not show any errors after the change
  • Pod Security Policy checks:
    • Any changed pod is covered by Pod Security Admission
    • Any changed pod is covered by Gatekeeper Pod Security Policies
    • The change does not cause any pods to be blocked by Pod Security Admission or Policies
  • Network Policy checks:
    • Any changed pod is covered by Network Policies
    • The change does not cause any dropped packets in the NetworkPolicy Dashboard
  • Audit checks:
    • The change does not cause any unnecessary Kubernetes audit events
    • The change requires changes to Kubernetes audit policy
  • Falco checks:
    • The change does not cause any alerts to be generated by Falco
  • Bug checks:
    • The bug fix is covered by regression tests

@Xartos Xartos requested a review from a team as a code owner January 15, 2025 12:20
Copy link
Contributor

@aarnq aarnq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and clear steps 👍

migration/ubuntu/20-to-24.md Outdated Show resolved Hide resolved
migration/ubuntu/20-to-24.md Outdated Show resolved Hide resolved
@Xartos Xartos requested review from OlleLarsson and aarnq January 16, 2025 07:35
migration/ubuntu/20-to-24.md Outdated Show resolved Hide resolved
migration/ubuntu/20-to-24.md Outdated Show resolved Hide resolved
migration/ubuntu/20-to-24.md Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename this file to 20.04-to-22.04-openstack.md to make it clearer that it is only for openstack.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that was an error on my part of course it should be 20.04-to-24.04-openstack.md 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I should've seen that as well 🙈

migration/ubuntu/20-to-24.md Outdated Show resolved Hide resolved
migration/ubuntu/20-to-24.md Outdated Show resolved Hide resolved
migration/ubuntu/20-to-24.md Outdated Show resolved Hide resolved
Copy link
Contributor

@Ajarmar Ajarmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Minor thing: the document is named 20.04-to-22.04, but it should be 20.04-to-24.04, right?

migration/ubuntu/20.04-to-22.04-openstack.md Outdated Show resolved Hide resolved
migration/ubuntu/20.04-to-22.04-openstack.md Outdated Show resolved Hide resolved
@Xartos Xartos requested review from aarnq, viktor-f and Ajarmar January 22, 2025 15:48
Copy link
Contributor

@Ajarmar Ajarmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update these ones as well?

- Update DNS records to point to the new control plane nodes

> [!NOTE]
> This is only needed if you are using DNS and are pointing that to the IPs of the control plane nodes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> This is only needed if you are using DNS and are pointing that to the IPs of the control plane nodes.
> Updating the DNS records is only needed if you are using DNS and are pointing that to the IPs of the control plane nodes.

- Update loadbalancer to use the endpoints of the new control plane nodes

> [!NOTE]
> This is only needed if you are using a loadbalancer in front of the API server.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> This is only needed if you are using a loadbalancer in front of the API server.
> Updating the loadbalancer is only needed if you are using a loadbalancer in front of the API server.

```

> [!NOTE]
> This will likely fail at some point in one or two ways:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> This will likely fail at some point in one or two ways:
> Removing the old control plane nodes will likely fail at some point in one or two ways:

- Remove the old control plane floating IPs from group vars under the key `supplementary_addresses_in_ssl_keys`

> [!NOTE]
> This is not needed if you are using a loadbalancer in front of the API server.
Copy link
Contributor

@Ajarmar Ajarmar Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> This is not needed if you are using a loadbalancer in front of the API server.
> Removing the old IPs from `supplementary_addresses_in_ssl_keys` is not needed if you are using a loadbalancer in front of the API server.

@Xartos
Copy link
Contributor Author

Xartos commented Jan 23, 2025

Could you update these ones as well?

I thought I searched for This but I've must've misspelled 🙈 I hope I got all now

Copy link
Contributor

@viktor-f viktor-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice that we can now do this migration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants