Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubespray fork for v2.26.0-ck8s2 #406

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Conversation

Ajarmar
Copy link
Contributor

@Ajarmar Ajarmar commented Jan 13, 2025

Warning

This is a public repository, ensure not to disclose:

  • personal data beyond what is necessary for interacting with this pull request, nor
  • business confidential information, such as customer names.

What kind of PR is this?

Required: Mark one of the following that is applicable:

  • kind/feature
  • kind/improvement
  • kind/deprecation
  • kind/documentation
  • kind/clean-up
  • kind/bug
  • kind/other

Optional: Mark one or more of the following that are applicable:

Important

Breaking changes should be marked kind/admin-change or kind/dev-change depending on type
Critical security fixes should be marked with kind/security

  • kind/admin-change
  • kind/dev-change
  • kind/security
  • kind/adr

What does this PR do / why do we need this PR?

Cherry-picked a commit for patch release v2.26.0-ck8s2.

Information to reviewers

Checklist

  • Proper commit message prefix on all commits
  • Change checks:
    • The change is transparent
    • The change is disruptive
    • The change requires no migration steps
    • The change requires migration steps
  • Metrics checks:
    • The metrics are still exposed and present in Grafana after the change
    • The metrics names didn't change (Grafana dashboards and Prometheus alerts are not affected)
    • The metrics names did change (Grafana dashboards and Prometheus alerts were fixed)
  • Logs checks:
    • The logs do not show any errors after the change
  • Pod Security Policy checks:
    • Any changed pod is covered by Pod Security Admission
    • Any changed pod is covered by Gatekeeper Pod Security Policies
    • The change does not cause any pods to be blocked by Pod Security Admission or Policies
  • Network Policy checks:
    • Any changed pod is covered by Network Policies
    • The change does not cause any dropped packets in the NetworkPolicy Dashboard
  • Audit checks:
    • The change does not cause any unnecessary Kubernetes audit events
    • The change requires changes to Kubernetes audit policy
  • Falco checks:
    • The change does not cause any alerts to be generated by Falco
  • Bug checks:
    • The bug fix is covered by regression tests

@Ajarmar Ajarmar requested a review from a team as a code owner January 13, 2025 18:54
Copy link
Contributor

@Xartos Xartos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add this commit as well?
kubernetes-sigs/kubespray@daad54a

@Ajarmar Ajarmar requested a review from Xartos January 14, 2025 08:46
@Ajarmar
Copy link
Contributor Author

Ajarmar commented Jan 14, 2025

Could we add this commit as well? kubernetes-sigs/kubespray@daad54a

I added it. Just for future consideration: Since the commit didn't exist upstream yet (PR still open), I had to add your fork as a remote to be able to cherry-pick it. For the sake of simplicity, might be better to do all our PRs towards upstream from the elastisys fork.

@Ajarmar Ajarmar merged commit 0437fb8 into main Jan 14, 2025
2 checks passed
@Ajarmar Ajarmar deleted the axel/v2.26.0-ck8s2-cherry-pick branch January 14, 2025 08:58
@Xartos
Copy link
Contributor

Xartos commented Jan 14, 2025

Could we add this commit as well? kubernetes-sigs/kubespray@daad54a

I added it. Just for future consideration: Since the commit didn't exist upstream yet (PR still open), I had to add your fork as a remote to be able to cherry-pick it. For the sake of simplicity, might be better to do all our PRs towards upstream from the elastisys fork.

Right, yea good point!

Ajarmar added a commit that referenced this pull request Jan 14, 2025
Ajarmar added a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants