-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: updated fork process #395
Conversation
docs/managing-fork.md
Outdated
### Step 7 | ||
|
||
Tag the latest commit in the fork release branch. `patch-number` starts at 1 and increments by one for every new `compliantkubernetes-kubespray` release. | ||
|
||
```sh | ||
cd <fork-directory> | ||
git switch "release-X.Y.Z-ck8s" | ||
git pull | ||
git tag -a "vX.Y.Z-ck8s<patch-number>" | ||
git push --tags | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't it better if we do this during the release step?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's included in the release steps, I just kept it here to sort of give the whole picture. Added a disclaimer now, or should I remove it from here entirely?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, haven't tested any of the steps this time around.
Co-authored-by: Olle Larsson <[email protected]>
e8671ce
to
ecf135e
Compare
Warning
This is a public repository, ensure not to disclose:
What kind of PR is this?
Required: Mark one of the following that is applicable:
Optional: Mark one or more of the following that are applicable:
Important
Breaking changes should be marked
kind/admin-change
orkind/dev-change
depending on typeCritical security fixes should be marked with
kind/security
What does this PR do / why do we need this PR?
Updated process of handling the kubespray fork.
Create one release branch
release-X.Y.Z-ck8s
in our fork per upstream releaseX.Y.Z
. We then tag the latest commit of that release branch withvX.Y.Z-ck8s<patch-number>
.Information to reviewers
Checklist
NetworkPolicy Dashboard